Repository navigation
openrknn: fix FP16 output copy — bit-exact vendor match - #93
Merged
Merged
Conversation
The non-4D output path copied n_elems bytes instead of ti->size bytes. For FP16 3D tensors like SmolVLM [1,1024,768], n_elems=786432 but the actual data size is 1,572,864 bytes (786432 × 2). This caused 50% of the output to be zero. Fix: use ti->size (byte count) instead of ti->n_elems (element count). Result: SmolVLM l0_mlp output is now **bit-exact** with vendor rknnlite2 (786432/786432 FP16 values match, cosine=1.000000). Also adds ORKNN_DUMP_ACT env var for activation BO post-run dump. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
28 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
One-line fix: non-4D output path copied
n_elemsbytes instead ofti->sizebytes. For FP16 3D tensors, this halved the output data (786432 bytes instead of 1572864).Result
SmolVLM l0_mlp: bit-exact with vendor rknnlite2
Test plan
🤖 Generated with Claude Code