test: verify Rolldown scope fix with Vite+ preview - #1
Draft
fengmk2 wants to merge 1 commit into
Draft
Conversation
fengmk2
force-pushed
the
test/vite-plus-preview-rolldown-fix
branch
from
September 7, 2026 09:27
a37d76f to
31fcda0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This child PR applies the Vite+ preview on top of PR #2.
The parent PR adds the regression workflow. Its build fails with Vite
8.2.0and Rolldown1.2.2.This PR pins the Vite+ preview build. The preview contains Vite
8.2.2, Rolldown1.2.7, and Oxc0.148.0.Rolldown PR #10809 includes the default-parameter scope fix. The same regression workflow passes with this dependency set.
The SSR build replaces the default value with
null. It emits onlydist/server.jsand does not resolve the browser-only import.