Skip to content

use script's baseurl for cssstylesheets #11706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

use script's baseurl for cssstylesheets #11706

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5c4a857
use script's baseurl for cssstylesheets
keithamus Sep 25, 2025
f3e56d9
Move capture of baseUrl up a step or two
keithamus Sep 25, 2025
86fbf69
tidy prose for dictionary
keithamus Sep 25, 2025
989bc0a
drop even more prose, be succinct, just use "with"
keithamus Sep 25, 2025
188e6cf
break inside literal
keithamus Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion source
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117337,14 +117337,18 @@ document.querySelector("button").addEventListener("click", bound);
<li><p>Set <var>script</var>'s <span data-x="concept-script-settings-object">settings
object</span> to <var>settings</var>.</p></li>

<li><p>Let <var>baseUrl</var> be <var>script</var>'s <span data-x="concept-script-base-url">base
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure script's baseURL is valid here -- we just created script in the first step of this algorithm and haven't initialized that field yet.

I see that other "create a module script" algos take the baseURL as a parameter, e.g. see create a javascript module script. It looks to me like "create a CSS module script" also needs that parameter. We'd pass in the "response's URL" as the baseURL here in the same way as is done for WASM module scripts and JS module scripts nearby.

It's a little more plumbing than I thought it'd be in #11629 (comment) but I hadn't realized at the time that the CSS module script's baseURL just gets set to null.

URL</span>.

<li><p>Set <var>script</var>'s <span data-x="concept-script-base-url">base URL</span> and
<span data-x="concept-script-script-fetch-options">fetch options</span> to null.</p></li>

<li><p>Set <var>script</var>'s <span data-x="concept-script-parse-error">parse error</span> and
<span data-x="concept-script-error-to-rethrow">error to rethrow</span> to null.</p></li>

<li><p>Let <var>sheet</var> be the result of running the steps to <span>create a constructed
<code>CSSStyleSheet</code></span> with an empty dictionary as the argument.</p></li>
<code>CSSStyleSheet</code></span> with: «[
"<code data-x="">baseUrl</code>" → <var>baseUrl</var> ]».</p></li>

<li>
<p>Run the steps to <span>synchronously replace the rules of a <code>CSSStyleSheet</code></span>
Expand Down