Add NavigationTransition.to, exposing the current navigate event's destination
#11692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noamr
changed the title
NavigationTransition.to, exposing the current navigate event's destination
noamr
force-pushed
the
navigation-transition-to
branch
from
3336abd to
50e0a20
Compare
domenic
approved these changes
Sep 25, 2025
source
Outdated
| <dt><code data-x=""><span data-x="dom-navigation">navigation</span>.<span data-x="dom-Navigation-transition">transition</span>.<span subdfn data-x="dom-NavigationTransition-to">to</span></code></dt> | ||
| <dd><p>The <code>NavigationDestination</code> of the transition. This can be useful to compare | ||
| against <code data-x="dom-Navigation-currentEntry">navigation.currentEntry</code> before the | ||
| navigation is <span data-x="concept-NavigationTransition-committed">committed</span>.</p></dd> |
There was a problem hiding this comment.
Nit: "compare against" makes it sound like === will work, which it will not. I'm not sure what the best rephrasing is...
There was a problem hiding this comment.
Maybe something along the lines of competing the different properties of the entry and destination
annevk
reviewed
Sep 25, 2025
domenic
reviewed
Sep 25, 2025
noamr
force-pushed
the
navigation-transition-to
branch
from
50e0a20 to
7036eef
Compare
zcorpan
reviewed
Sep 25, 2025
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Sep 25, 2025
This exposes the destination of an ongoing navigation. Spec PR: whatwg/html#11692 I2P: https://groups.google.com/a/chromium.org/d/msgid/blink-dev/68d4ff4d.2b0a0220.29ae18.0091.GAE%40google.com [email protected] Bug: 447171238 Change-Id: I1d2fbb7c0b7f2656ca4392be4d1beac34d9012ac
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Sep 25, 2025
This exposes the destination of an ongoing navigation. Spec PR: whatwg/html#11692 I2P: https://groups.google.com/a/chromium.org/d/msgid/blink-dev/68d4ff4d.2b0a0220.29ae18.0091.GAE%40google.com [email protected] Bug: 447171238 Change-Id: I1d2fbb7c0b7f2656ca4392be4d1beac34d9012ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6982944 Reviewed-by: Nate Chapin <[email protected]> Commit-Queue: Noam Rosenthal <[email protected]> Cr-Commit-Position: refs/heads/main@{#1520724}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Sep 25, 2025
This exposes the destination of an ongoing navigation. Spec PR: whatwg/html#11692 I2P: https://groups.google.com/a/chromium.org/d/msgid/blink-dev/68d4ff4d.2b0a0220.29ae18.0091.GAE%40google.com [email protected] Bug: 447171238 Change-Id: I1d2fbb7c0b7f2656ca4392be4d1beac34d9012ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6982944 Reviewed-by: Nate Chapin <[email protected]> Commit-Queue: Noam Rosenthal <[email protected]> Cr-Commit-Position: refs/heads/main@{#1520724}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Sep 25, 2025
This exposes the destination of an ongoing navigation. Spec PR: whatwg/html#11692 I2P: https://groups.google.com/a/chromium.org/d/msgid/blink-dev/68d4ff4d.2b0a0220.29ae18.0091.GAE%40google.com [email protected] Bug: 447171238 Change-Id: I1d2fbb7c0b7f2656ca4392be4d1beac34d9012ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6982944 Reviewed-by: Nate Chapin <[email protected]> Commit-Queue: Noam Rosenthal <[email protected]> Cr-Commit-Position: refs/heads/main@{#1520724}
zcorpan
approved these changes
Oct 1, 2025
|
@zcorpan can I mark it as "two implementers interested"? People said it was reasonable but I want to make sure. If so, I'll open implementation bugs and fill in the rest of the checkboxes. |
|
Yes. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
NavigationTransition.to, exposing the currentnavigateevent's destination.This was not necessary before as navigations were committed synchronously, but with precommit handlers this
exposes information about an ongoing navigation.
The destination is set when the
NavigationTransitionobject is created, and remains stable throughout.Closes #11690.
(See WHATWG Working Mode: Changes for more details.)
/nav-history-apis.html ( diff )