Add language filter to sync-ingredients management command. #1875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anguage code if desired.
| mock_request.assert_called_with( | ||
| 'https://wger.de/api/v2/ingredient/?limit=999', | ||
| 'https://wger.de/api/v2/ingredient/?limit=999&language=2', |
There was a problem hiding this comment.
I'd add a new simple test here, something like def test_ingredient_sync_languages that only checks that the correct URL is called
| url = make_uri( | ||
| INGREDIENTS_ENDPOINT, | ||
| server_url=remote_url, | ||
| query={'limit': API_MAX_ITEMS, 'language': language_id}, |
There was a problem hiding this comment.
I'd just allow passing all languages at once, seems easier that way. For this we just need to add 'in' to IngredientFilterSet, like in 'id'. Then we can do query={'limit': API_MAX_ITEMS, 'language__in': ','.join([languages])} (this also works if we only pass one)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
python manage.py sync-ingredients --languages=en,fr,esPlease check that the PR fulfills these requirements
wger.nutrition.tests.test_xync.TestSyncMethodshas been slightly modified to ensure uri was called with proper filter.Other questions
(e.g. database migration)? No