Flexible routines #682
Open
Flexible routines #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was only needed for the custom scrolling background / header that was removed some time ago
# Conflicts: # test/weight/weight_screen_test.mocks.dart
There are a lot of common steps that are always the same. This will specially important once we edit all the other configs and their max siblings
Also make sure that we don't update the routine while editing, since some of the changes could pull the rug under our feet and felt strange. Now there's a manual refresh button for the resulting routine
instead of loading the same data from the server
The problem was that some of the previous changes were asynchronous and would not always represent the actual current state. This solution works, but is a bit verbose and perhaps overly complicated?
# Conflicts: # pubspec.lock
…rors Seems this is the only form to make it work within the SingleChildScrollView
This makes sure that all the structures are present and have the correct content (dayData, etc.)
This makes sure that all the structures are present and have the correct content (dayData, etc.). Also, add more feedback to the user for some operations that take a bit longer due to loading the whole routine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flutter changes for the flexible routines