You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fixes Tempo session voucher signing for access-key accounts and tightens Tempo charge source chain handling.
Motivation
Access-key session vouchers need to sign the voucher digest as the access-key address. viem 2.51.0 added sign({ hash, raw: true }), which lets mppx produce escrow-compatible raw signatures without requiring callers to pass a separate direct signer.
Changes
Replaced Tempo session authorizedSigner options with voucherSigner accounts in src/tempo/client/Session.ts and src/tempo/client/SessionManager.ts.
Updated voucher signing in src/tempo/session/Voucher.ts to sign typed-data digests with raw: true, normalize envelopes, and keep TIP-1020 verification guarded off.
Centralized access-key signer-address resolution in src/tempo/internal/account.ts.
Fixed src/tempo/client/Charge.ts to require a chain ID from the challenge or client and use canonical proof sources.
Bumped viem to 2.51.0 and ox to 0.14.24.
Testing
./node_modules/.bin/vp test src/tempo/session/Voucher.test.ts src/tempo/client/ChannelOps.test.ts src/tempo/client/Session.test.ts
Next steps: Take a moment to review the security alert above. Review
the linked package source code to understand the potential risk. Ensure the
package is not malicious before proceeding. If you're unsure how to proceed,
reach out to your security team or ask the Socket team for help at
[email protected].
Suggestion: Publish the HTTP URL dependency to a public or private package repository and consume it from there.
Mark the package as acceptable risk. To ignore this alert only
in this pull request, reply with the comment
@SocketSecurity ignore npm/[email protected]. You can
also ignore all packages with @SocketSecurity ignore-all.
To ignore an alert for all future pull requests, use Socket's Dashboard to
change the triage state of this alert.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Tempo session voucher signing for access-key accounts and tightens Tempo charge source chain handling.
Motivation
Access-key session vouchers need to sign the voucher digest as the access-key address. viem 2.51.0 added
sign({ hash, raw: true }), which lets mppx produce escrow-compatible raw signatures without requiring callers to pass a separate direct signer.Changes
authorizedSigneroptions withvoucherSigneraccounts insrc/tempo/client/Session.tsandsrc/tempo/client/SessionManager.ts.src/tempo/session/Voucher.tsto sign typed-data digests withraw: true, normalize envelopes, and keep TIP-1020 verification guarded off.src/tempo/internal/account.ts.src/tempo/client/Charge.tsto require a chain ID from the challenge or client and use canonical proof sources.viemto 2.51.0 andoxto 0.14.24.Testing
./node_modules/.bin/vp test src/tempo/session/Voucher.test.ts src/tempo/client/ChannelOps.test.ts src/tempo/client/Session.test.tspnpm check:typespnpm checkgit diff --check