Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#30: 회원가입 서버와 연동을 해요 #35

Merged
merged 16 commits into from
Jul 19, 2024
Merged

#30: 회원가입 서버와 연동을 해요 #35

merged 16 commits into from
Jul 19, 2024

Conversation

flash159483
Copy link
Contributor

1. 📄 관련된 이슈 및 소개

#30 #31

2. 🔥 변경된 점

회원가입 mock 서버와 연동을 진행했어요

3. ✅ 필수 체크 사항

  • 카카오 로그인 진행
  • DataStore 도입
  • idToken 서버 전송
  • 자동 로그인
  • authtoken, refreshtoken 받고 저장
  • 학교 정보를 가져와 사용자한테 보여줘요
  • 회원가입을 끝낼때 가입 정보를 서버에 전송해요

4. 📸 작업물 사진 공유(선택)

signup.webm

5. 💡알게된 혹은 궁금한 사항

@flash159483 flash159483 added 🌱기능🌱 새로운 기능을 추가해요 ! 🍩브라우니🍩 24기 정승원 🌟머지 해주세요🌟 코드 리뷰가 완료된 뒤 PR을 올린사람이 Merge를 하면 되는 단계입니다. labels Jul 17, 2024
@flash159483 flash159483 requested a review from jeongjaino July 17, 2024 13:44
@flash159483 flash159483 self-assigned this Jul 17, 2024
@flash159483 flash159483 reopened this Jul 17, 2024
This was linked to issues Jul 17, 2024
WS-291 [FEATURE]: 회원가입 서버와 연동 #30
Closed
WS-292 [FEATURE]: 서버로 부터 소셜 로그인 token을 받아요 #31
Closed
jeongjaino
jeongjaino reviewed Jul 18, 2024
View reviewed changes
Copy link
Member

@jeongjaino jeongjaino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

승원찡 수고 많았어용~~ DataStore까지 척척하셨네요 👍 코멘트 확인 부탁드려용~~

app/src/main/kotlin/com/bff/wespot/di/NavigationModule.kt Show resolved Hide resolved
core/common/src/main/kotlin/com/danggeun/common/di/CoroutineModule.kt Show resolved Hide resolved
core/model/src/main/kotlin/com/bff/wespot/model/constants/LoginState.kt Show resolved Hide resolved
core/navigation/src/androidTest/java/com/danggeun/navigation/ExampleInstrumentedTest.kt Outdated Show resolved Hide resolved
core/navigation/src/main/java/com/danggeun/navigation/util/Extension.kt Show resolved Hide resolved
data/src/main/kotlin/com/bff/wespot/data/local/WeSpotDataStore.kt Show resolved Hide resolved
feature/auth/src/main/kotlin/com/bff/wespot/auth/AuthActivity.kt Show resolved Hide resolved
feature/auth/src/main/kotlin/com/bff/wespot/auth/viewmodel/AuthViewModel.kt Show resolved Hide resolved
feature/auth/src/main/kotlin/com/bff/wespot/auth/viewmodel/AuthViewModel.kt Show resolved Hide resolved
gradle/libs.versions.toml Outdated Show resolved Hide resolved
@flash159483 flash159483 reopened this Jul 19, 2024
@flash159483 flash159483 merged commit b6184ee into develop Jul 19, 2024
13 checks passed
@flash159483 flash159483 deleted the feature/flash159483/#30 branch July 19, 2024 14:27
jeongjaino
jeongjaino reviewed Jul 19, 2024
View reviewed changes
Copy link
Member

@jeongjaino jeongjaino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMGLTLGLTNGMTLMGLMGLMTLMGLMTLM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeongjaino jeongjaino jeongjaino approved these changes

Assignees

@flash159483 flash159483

Labels
🌟머지 해주세요🌟 코드 리뷰가 완료된 뒤 PR을 올린사람이 Merge를 하면 되는 단계입니다. 🌱기능🌱 새로운 기능을 추가해요 ! 🍩브라우니🍩 24기 정승원
Projects
None yet
Milestone
No milestone
2 participants
@flash159483 @jeongjaino