Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#13 : 쪽지 전용 컴포넌트 구현 #24

Merged
merged 8 commits into from
Jul 10, 2024
Merged

#13 : 쪽지 전용 컴포넌트 구현 #24

merged 8 commits into from
Jul 10, 2024

Conversation

jeongjaino
Copy link
Member

1. 📄 관련된 이슈 및 소개

#13 쪽지 공용 컴포넌트 구현

2. 🔥 변경된 점

  1. Toast 공용 컴포넌트를 구현하였습니다.
  2. Letter List 공용 컴포넌트를 구현하였습니다.
  3. 이전 제거했던 KtLint를 다시 ui, designSystem에 적용하였습니다.
  • MultiLine, Fuction Wrapping 친구들은 제거했어요 !

3. ✅ 필수 체크 사항

  • Toast 구현시 Icon을 ImageVector로 지정하는데 따로 노출되지 않는 이슈가 있었는데, Icon 내 tint 속성을 UnSpecified로 수정하여 해결했어요. 혹시 이부분 알고 계시면 확인 부탁드려요 ..!
  • KtLint 다시 추가해서, 지금 올라간 부분들 KtLint Formatting 적용되어 있습니다.

4. 📸 작업물 사진 공유(선택)

image image

5. 💡알게된 혹은 궁금한 사항

@jeongjaino jeongjaino added 🌱기능🌱 새로운 기능을 추가해요 ! 🍻제이콥🍻 24기 정진호 🔥리뷰 기다리는 중🔥 PR을 올리고 코드리뷰를 기다리고 있는 상태입니다. 📄문서📄 README, Template과 같은 문서 작업 labels Jul 7, 2024
@jeongjaino jeongjaino requested a review from flash159483 July 7, 2024 07:00
@jeongjaino jeongjaino self-assigned this Jul 7, 2024
@jeongjaino jeongjaino linked an issue Jul 7, 2024 that may be closed by this pull request
WS-210 [FEATURE]: 쪽지 공용 컴포넌트 구현 #13
Closed
3 tasks
flash159483
flash159483 requested changes Jul 8, 2024
View reviewed changes
designsystem/src/main/kotlin/com/bff/wespot/designsystem/component/indicator/WSToast.kt Outdated
Box(
modifier = Modifier
.clip(WeSpotThemeManager.shapes.extraLarge)
.background(color = Color.White)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

색상 사용할때 Color로 부터 바로 가져오지 말고 최대한 WeSpotManager.colors에서 가져오고 없으면 Colors.kt에 있는 걸 쓰는 것을 권장드려요

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

해당 코드 잠깐 확인해보려고 넣었는데, 반영되어버렸네용 ..

(아니 승원짱 토스트 컬러 뭐야~~~ 센스 만점)

확인후 반영했습니당

designsystem/src/main/kotlin/com/bff/wespot/designsystem/component/indicator/WSToast.kt Outdated
override fun icon(): ImageVector = ImageVector.vectorResource(R.drawable.check)

@Composable
override fun textColor(): Color = Gray900
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WeSpotManager에 있는 backgroundcolor로 가져오는 것을 권장해요.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

최고야. 당신.

확인 후반영했어요 ~!

designsystem/src/main/kotlin/com/bff/wespot/designsystem/component/list/WSLetterItem.kt Outdated
modifier = Modifier
.clip(WeSpotThemeManager.shapes.medium)
.size(width = 154.dp, height = 200.dp)
.background(Gray700)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기도 cardbackground를 쓰는게 좋을 것 같아요

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

최고야. 당신. 캬캬캬캬

확인 후 반영했어용

designsystem/src/main/kotlin/com/bff/wespot/designsystem/component/indicator/WSToast.kt
verticalAlignment = Alignment.CenterVertically,
) {
Icon(
painter = rememberVectorPainter(toastType.icon()),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저는 이걸 painterResource로 처리하는데 혹시 잘 되는지 확인해주실 수 있나요

@jeongjaino
Copy link
Member Author

띠용

jeongjaino
jeongjaino commented Jul 10, 2024
View reviewed changes
Copy link
Member Author

@jeongjaino jeongjaino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

늦어서 죄송함다..!! 확인 후 반영했어용,,, (승원짱 PR 지금 보러가는중)

designsystem/src/main/kotlin/com/bff/wespot/designsystem/component/indicator/WSToast.kt Outdated
Box(
modifier = Modifier
.clip(WeSpotThemeManager.shapes.extraLarge)
.background(color = Color.White)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

해당 코드 잠깐 확인해보려고 넣었는데, 반영되어버렸네용 ..

(아니 승원짱 토스트 컬러 뭐야~~~ 센스 만점)

확인후 반영했습니당

designsystem/src/main/kotlin/com/bff/wespot/designsystem/component/indicator/WSToast.kt Outdated
override fun icon(): ImageVector = ImageVector.vectorResource(R.drawable.check)

@Composable
override fun textColor(): Color = Gray900
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

최고야. 당신.

확인 후반영했어요 ~!

designsystem/src/main/kotlin/com/bff/wespot/designsystem/component/list/WSLetterItem.kt Outdated
modifier = Modifier
.clip(WeSpotThemeManager.shapes.medium)
.size(width = 154.dp, height = 200.dp)
.background(Gray700)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

최고야. 당신. 캬캬캬캬

확인 후 반영했어용

@jeongjaino jeongjaino merged commit 98955ce into develop Jul 10, 2024
2 checks passed
@github-actions github-actions bot added the 🌟머지 해주세요🌟 코드 리뷰가 완료된 뒤 PR을 올린사람이 Merge를 하면 되는 단계입니다. label Jul 10, 2024
@flash159483 flash159483 deleted the feature/jaino/#13 branch August 28, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flash159483 flash159483 flash159483 approved these changes

Assignees

@jeongjaino jeongjaino

Labels
🌟머지 해주세요🌟 코드 리뷰가 완료된 뒤 PR을 올린사람이 Merge를 하면 되는 단계입니다. 🌱기능🌱 새로운 기능을 추가해요 ! 🍻제이콥🍻 24기 정진호 📄문서📄 README, Template과 같은 문서 작업 🔥리뷰 기다리는 중🔥 PR을 올리고 코드리뷰를 기다리고 있는 상태입니다.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WS-210 [FEATURE]: 쪽지 공용 컴포넌트 구현
2 participants
@jeongjaino @flash159483