Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#191: 이미지 업로드 화면 추가해요 #199

Merged
merged 8 commits into from
Nov 13, 2024

Conversation

flash159483
Copy link
Contributor

1. 📄 관련된 이슈 및 소개

close #191

2. 🔥 변경된 점

회원가입에서 이미지 업로드 화면 추가해요

3. ✅ 필수 체크 사항

  • 이미지 path 가져오는 기능 추가
  • 이미지 보여주는 화면 추가

4. 📸 작업물 사진 공유(선택)

untitled_compressed.mp4

@flash159483 flash159483 added 🌱기능🌱 새로운 기능을 추가해요 ! 🍩브라우니🍩 24기 정승원 🌟머지 해주세요🌟 코드 리뷰가 완료된 뒤 PR을 올린사람이 Merge를 하면 되는 단계입니다. labels Nov 11, 2024
@flash159483 flash159483 self-assigned this Nov 11, 2024
@flash159483 flash159483 changed the title Feature/flash159483/#191 #191: 이미지 업로드 화면 추가해요 Nov 11, 2024
@jeongjaino jeongjaino linked an issue Nov 11, 2024 that may be closed by this pull request
2 tasks
Copy link
Member

@jeongjaino jeongjaino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

짜란다 짜란다 짜란다~~

한줄소개 수정 몰래 커밋하나 끼워넣기 ~

Comment on lines 130 to 133
onValueChange = { introduction ->
if (introduction.length > 20) {
Timber.d("Introduction length is over 20")
error = true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

로깅 삭제 삭제 삭제 !!

Comment on lines 96 to 98
.build(),
contentDescription = "",
modifier = Modifier
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

디스크립션 디스크립션 !!

@flash159483 flash159483 merged commit 894d2e6 into develop Nov 13, 2024
@flash159483 flash159483 deleted the feature/flash159483/#191 branch November 13, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟머지 해주세요🌟 코드 리뷰가 완료된 뒤 PR을 올린사람이 Merge를 하면 되는 단계입니다. 🌱기능🌱 새로운 기능을 추가해요 ! 🍩브라우니🍩 24기 정승원
Projects
None yet
2 participants