Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#179 : 알림 아이콘 충돌 해결해요 + 리드미 업데이트 #180

Merged
merged 5 commits into from
Oct 5, 2024

Conversation

jeongjaino
Copy link
Member

@jeongjaino jeongjaino commented Oct 3, 2024

1. 📄 관련된 이슈 및 소개

#179 : 알림 아이콘 충돌 해결해요

관련스레드
https://discord.com/channels/1241364675657203742/1241739388975714458/1291328245152743426

2. 🔥 변경된 점

푸시 아이콘 이름을 변경했어요 !

readme 업데이트 진행했어요 !

3. ✅ 필수 체크 사항

혹시 또 중복된 이름 사용하고 있는지 확인했습니다.

4. 📸 작업물 사진 공유(선택)

전과 후 입니다 !

image image

5. 💡알게된 혹은 궁금한 사항

모듈 그래프 라이브러리

https://github.com/jraska/modules-graph-assert?tab=readme-ov-file#graphviz-graph-export

./gradlew generateModulesGraphvizText -Pmodules.graph.output.gv=all_modules.gv
dot -Tsvg "all_modules.gv" | svgo --multipass --pretty --output="module_graph.svg" -
  • graphviz, svgo brew install 필수 !

@jeongjaino jeongjaino added 🍻제이콥🍻 24기 정진호 🔨픽스🔨 버그 및 잠재적 문제 해결 labels Oct 3, 2024
@jeongjaino jeongjaino requested a review from flash159483 October 3, 2024 09:19
@jeongjaino jeongjaino self-assigned this Oct 3, 2024
@jeongjaino jeongjaino linked an issue Oct 3, 2024 that may be closed by this pull request
1 task
@jeongjaino jeongjaino changed the title #179 : 알림 아이콘 충돌 해결해요 #179 : 알림 아이콘 충돌 해결해요 + 리드미 업데이트 Oct 3, 2024
@jeongjaino jeongjaino closed this Oct 3, 2024
@jeongjaino jeongjaino reopened this Oct 3, 2024
Copy link
Contributor

@flash159483 flash159483 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

변경이 왤케 많아 보일까 리드미땜인가 🙃

@jeongjaino jeongjaino merged commit 3a2cca7 into develop Oct 5, 2024
3 checks passed
@flash159483 flash159483 deleted the feature/jaino/#179 branch November 30, 2024 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍻제이콥🍻 24기 정진호 🔨픽스🔨 버그 및 잠재적 문제 해결
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WS-430 [FIX]: 알림 화면 노티 icon 충돌 이슈 해결해요
2 participants