Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#110: 아이콘 및 Splash 수정 #113

Merged
merged 5 commits into from
Aug 19, 2024
Merged

Conversation

flash159483
Copy link
Contributor

1. 📄 관련된 이슈 및 소개

close #110

2. 🔥 변경된 점

앱, splash 아이콘을 추가해요
splash 31버전 이전도 대응하게 추가해요

3. ✅ 필수 체크 사항

  • 아이콘 수정
  • 스플레쉬 추가
  • Splash 31버전 이하 대응

4. 📸 작업물 사진 공유(선택)

untitled.webm

5. 💡알게된 혹은 궁금한 사항

31버전 이상부터는 PreDrawListener 때문에 잠시 흰화면이 나오는데 이걸 해결하려면 autologin 로직을 옮기거나 splash를 옮겨야하는데 나중에 생각할래..

@flash159483 flash159483 added 🌱기능🌱 새로운 기능을 추가해요 ! 🍩브라우니🍩 24기 정승원 labels Aug 18, 2024
@flash159483 flash159483 self-assigned this Aug 18, 2024
@flash159483 flash159483 changed the title Feature/flash159483/#110 #110: 아이콘 및 Splash 수정 Aug 18, 2024
@flash159483 flash159483 requested a review from jeongjaino August 18, 2024 07:55
Copy link
Member

@jeongjaino jeongjaino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생했어영 브라우닝~~ 드디어 앱 아이콘이 생겼넹~~

Comment on lines +6 to +12
<style name="Theme.WeSpot.Starting" parent="Theme.WeSpot">
<item name="android:statusBarColor">#1C1B1E</item>
<item name="android:navigationBarColor">#1C1B1E</item>
<item name="android:windowLightStatusBar">false</item>
<item name="windowSplashScreenBackground">@drawable/icon</item>
<item name="android:backgroundDimEnabled">false</item>
<item name="android:windowContentOverlay">@null</item>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Comment on lines +6 to +14
<style name="Theme.Wespot.Starting" parent="Theme.SplashScreen">
<item name="android:statusBarColor">#1C1B1E</item>
<item name="android:navigationBarColor">#1C1B1E</item>
<item name="android:windowLightStatusBar">false</item>
<item name="android:windowSplashScreenBackground">#1C1B1E</item>
<item name="android:windowSplashScreenAnimatedIcon">@drawable/icon</item>
<item name="android:windowSplashScreenIconBackgroundColor">#1C1B1E</item>
<item name="android:windowSplashScreenAnimationDuration">0</item>
<item name="postSplashScreenTheme">@style/Theme.WeSpot</item>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@github-actions github-actions bot added the 🌟머지 해주세요🌟 코드 리뷰가 완료된 뒤 PR을 올린사람이 Merge를 하면 되는 단계입니다. label Aug 18, 2024
@flash159483 flash159483 merged commit 8409dba into develop Aug 19, 2024
4 checks passed
@flash159483 flash159483 deleted the feature/flash159483/#110 branch August 19, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟머지 해주세요🌟 코드 리뷰가 완료된 뒤 PR을 올린사람이 Merge를 하면 되는 단계입니다. 🌱기능🌱 새로운 기능을 추가해요 ! 🍩브라우니🍩 24기 정승원
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WS-393 [FEATURE]: 아이콘 및 Splash 수정
2 participants