feat: auto deduce content type when requesting data#49
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #49 +/- ##
==========================================
+ Coverage 80.19% 80.46% +0.26%
==========================================
Files 7 7
Lines 409 430 +21
==========================================
+ Hits 328 346 +18
- Misses 59 61 +2
- Partials 22 23 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
wenchy
requested changes
Oct 16, 2025
options.go
Outdated
Comment on lines
213
to
214
| // Data sets data of request body. It also deduces and sets the Content-Type | ||
| // for the input data. |
Owner
There was a problem hiding this comment.
Add more details for deducing different content types based on data types:
- "application/json": struct, slice(except []byte), and map
- auto deduce by [http.DetectContentType]: []byte, io.Reader
- "text/plain": others
Comment on lines
+196
to
+197
| default: | ||
| return plainTextType, fmt.Appendf(nil, "%v", bodyValue.Interface()), nil |
Owner
There was a problem hiding this comment.
If the data type is io.Reader, we should also process it well. just like: https://github.com/go-resty/resty/blob/v3/middleware.go#L428C7-L428C16
Collaborator
Author
There was a problem hiding this comment.
Done. We check if the input data implements io.Reader first before checking its reflect.Kind.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.