Issue 3267: fixed wps226 location

CHANGELOG.md

@@ -29,9 +29,9 @@ This version introduces `wps` CLI tool.
 - Fixes `WPS115` false-positive on `Enum` attributes, #3238
 - Removes duplicated `WPS312`, #3239
 - Fixes `WPS432`, now it shows literal num, #1402
+- Fixes `WPS226`, now it points to the first string literal occurrence, #3267
 - Fixes `WPS605` false-positive on `@staticmethod`, #3292
 
-
 ## 1.0.0
 
 ### Ruff

tests/test_visitors/conftest.py

@@ -100,3 +100,18 @@ def factory(
         assert reproduction.message() == violation.message()
 
     return factory
+
+
+@pytest.fixture(scope='session')
+def assert_error_location():
+    """Helper function to assert visitor violation location is expected."""
+
+    def factory(
+        visitor: BaseVisitor,
+        expected: tuple[int, int],
+    ) -> None:
+        assert len(visitor.violations) == 1
+        violation = visitor.violations[0]
+        assert violation._location() == expected  # noqa: SLF001
+
+    return factory

tests/test_visitors/test_ast/test_complexity/test_overuses/test_overused_string.py

@@ -96,6 +96,8 @@ def function() -> Dict[int, {0}]:
     ...
 """
 
+EXPECTED_LOCATION = (2, 8)
+
 
 @pytest.mark.parametrize(
     'strings',
@@ -159,6 +161,7 @@ def test_string_overuse_settings(
 def test_string_overuse(
     assert_errors,
     assert_error_text,
+    assert_error_location,
     parse_ast_tree,
     default_options,
     strings,
@@ -167,7 +170,6 @@ def test_string_overuse(
 ):
     """Ensures that over-used strings raise violations."""
     tree = parse_ast_tree(strings.format(prefix + string_value))
-
     visitor = StringOveruseVisitor(default_options, tree=tree)
     visitor.run()
 
@@ -177,6 +179,7 @@ def test_string_overuse(
         string_value.replace('"', '') or "''",
         default_options.max_string_usages,
     )
+    assert_error_location(visitor, EXPECTED_LOCATION)
 
 
 @pytest.mark.parametrize(

wemake_python_styleguide/violations/complexity.py

@@ -881,6 +881,8 @@ class OverusedStringViolation(MaybeASTViolation):
     single space `' '`, new line `'\n'`, `'\r\n'` and tabulator `'\t'`
     do not count against string literal overuse limit.
 
+    The violation points to the first occurrence of the overused string literal.
+
     Reasoning:
         When some string is used more than several time in your code,
         it probably means that this string is a meaningful constant

wemake_python_styleguide/visitors/ast/complexity/overuses.py

@@ -67,6 +67,11 @@ def __init__(self, *args, **kwargs) -> None:
             int,
         ] = defaultdict(int)
 
+        self._string_constants_first_node: defaultdict[
+            AnyTextPrimitive,
+            ast.Constant,
+        ] = defaultdict(lambda: ast.Constant(value=None))
+
     def visit_any_string(self, node: ast.Constant) -> None:
         """Restricts to over-use string constants."""
         self._check_string_constant(node)
@@ -81,6 +86,9 @@ def _check_string_constant(self, node: ast.Constant) -> None:
         if node.value in self._ignored_string_constants:
             return
 
+        if node.value not in self._string_constants_first_node:
+            self._string_constants_first_node[node.value] = node
+
         self._string_constants[node.value] += 1
 
     def _post_visit(self) -> None:
@@ -90,6 +98,7 @@ def _post_visit(self) -> None:
                     complexity.OverusedStringViolation(
                         text=source.render_string(string) or "''",
                         baseline=self.options.max_string_usages,
+                        node=self._string_constants_first_node[string],
                     ),
                 )