-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add markers/tags for migration tests #138
Conversation
Codecov Report
@@ Coverage Diff @@
## master #138 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 17 17
Lines 314 316 +2
Branches 32 33 +1
=========================================
+ Hits 314 316 +2
Continue to review full report at Codecov.
|
assert MIGRATION_TEST_MARKER in output_text | ||
|
||
|
||
def test_pytest_markers(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sobolevn what do you think about using pytester
plugin to add more detailed tests of our pytest plugin?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, sure! Let's open a new issue for it! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added issue #140
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work!
I suggest to fix docs a bit and let's merge it! 👍
README.md
Outdated
To run only migrations test, use `-m` option: | ||
|
||
```bash | ||
pytest -m migration_test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's also give an example here how to ignore migration tests:
pytest -m migration_test # runs only migraion tests
pytest -m "not migration_test" # runs all except migration tests
README.md
Outdated
To run only migrations tests, use `--tag` option: | ||
|
||
```bash | ||
python mange.py test --tag=migration_test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have something similar to -m "not ..."
in unittest
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, there is a CLI option --exclude-tag
, I will add usage example to the docs
assert MIGRATION_TEST_MARKER in output_text | ||
|
||
|
||
def test_pytest_markers(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, sure! Let's open a new issue for it! 👍
@skarzi do we have any blockers for a new version to be released? |
Probably 1 blocker which is MySQL support - #122 (comment) I will take care of it whenever I find some time |
Closes #96