Replace digest dependency with crc32c #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both digest and crc32c are importing crc32c_extend symbol which results in GHC linker fatal error when both dependencies are in the dependency tree. There is a PR open in digest which goes in the direction of removing crc32c C library: TeofilC/digest#24 in favour of using crc32c haskell library directly.
Contributor
Author
|
@edsko is this something you'd consider merging? |
Collaborator
|
Yes, I think so. Let me just double-check with the client, but if they're fine with it, I'll merge and release. Thanks for the PR! |
Collaborator
|
Released as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both
digestandcrc32care importingcrc32c_extendsymbol from acrc32cC library which results in GHC linker fatal error when cross-compiling on Windows (see TeofilC/digest#24) and when both dependencies are in the dependency tree. There is a PR open indigestwhich goes in the direction of removingcrc32cC library dependency: TeofilC/digest#24 in favour of usingcrc32chaskell library directly, thus removingData.Digest.CRC32Cexport (used insnappy-c) fromdigest.