Skip to content

Fixes to 19.0 migration and JS libraries update#7

Open
juppe wants to merge 5 commits intoweinni2000:19.0-mig-base_geoenginefrom
ahkio:ahkio/19.0-mig-base-geoengine
Open

Fixes to 19.0 migration and JS libraries update#7
juppe wants to merge 5 commits intoweinni2000:19.0-mig-base_geoenginefrom
ahkio:ahkio/19.0-mig-base-geoengine

Conversation

@juppe
Copy link

@juppe juppe commented Mar 6, 2026

Improve WKT vs WKB detection in geometry conversion
Update frontend library dependencies: OpenLayers, Chroma.js, Geostats
Refactor geo library loading to use dynamic imports

Also cherry-picked in the two commits from: OCA#431

juppe added 3 commits March 5, 2026 23:05
Update the geometry string parsing logic to automatically attempt WKB hex loading even if the WKB flag is not explicitly set. This handles cases where a hex string is provided but treated as WKT, falling back to WKT parsing only if hex validation fails.
Upgrades external libraries Chroma.js, Geostats, and OpenLayers to newer versions to ensure compatibility and leverage recent improvements. This includes transition to new folder structures for versioned assets.
Moves OpenLayers, Chroma.js, and Geostats out of the standard asset bundle to a dedicated dynamic loading utility. This centralization prevents potential bundler conflicts and ensures libraries are loaded asynchronously only when required. Updates the GeoEngine renderer and map edit widget to utilize this shared loader for dependency initialization.
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @juppe, your pull request is larger than the review limit of 150000 diff characters

   Updated field label from "Params" to "Params WMS"
of params_wms
   attribute_field_id domain is updated to use values
based on geo_field_id.model_id
@juppe
Copy link
Author

juppe commented Mar 19, 2026

@weinni2000 What do you think about this approach? If you review and merge this PR into your branch and then update your PR @ oca/geospatial to include these fixes?

@weinni2000
Copy link
Owner

@juppe:
Hi, I'm a little bit short of time at the moment if you want to take over it would be very appriciated.

@juppe
Copy link
Author

juppe commented Mar 19, 2026

@juppe: Hi, I'm a little bit short of time at the moment if you want to take over it would be very appriciated.

@weinni2000 I can take over. However, I'm not that much of a git wizard so that I would know how to exactly take over from here.

We have your fork and your branch and your PR @OCA. Then we have my work that is done on top of yours. What kind if git tricks do we need to do for me to take over?

@weinni2000
Copy link
Owner

@juppe:
If it's easier for you just start a new PR with your current state (mine + yours), then I can close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants