-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Complete_plants Dataset #100
base: main
Are you sure you want to change the base?
Conversation
@Mohitkumar6122 could you give me a command or a set of commands you used to test this PR and the results. For example. DeepTest(fix-module) $ retriever install sqlite iris
=> Installing iris
Downloading bezdekIris.data: 3.00B [00:00, 7.63B/s]
Installing iris_Iris
Progress: 100%|████████████████████████████████████████████████████████████████████████████████████████████| 151/151 [00:00<00:00, 36192.92rows/s]
Done! |
@henrykironde How to test a specific PR ? |
@Mohitkumar6122, when you create a script, you should test if it actually works. |
@henrykironde, Ok, so I tested this, and got this output : |
Nice update. Now I will show you the same script. File names use Inside the script, the name is the same as the file name but with "name": "new-script", The script you are working on is already in the retriever Note: the script does not work because the url needs updating. once you are done, rename your script plant_taxonomy_us.json and push the changes. This will be the same as repairing the script. Please also read the docs on creating a script |
Looks good, a few things we need to take care of.
|
Sure I will do it :-). |
You have a miss spelling, taxonomy hence we have two files now |
@henrykironde , What are your suggestions ? |
Am yet to review this. I have some work that needs to be done but will get back to you soon. Planning for Monday afternoon. |
Sure @henrykironde whenever you like ! |
@Mohitkumar6122 so could you run |
@henrykironde, how should I access data stored in Postgres server ? |
Am going to fix this is about 2 hours |
Any updates on this @henrykironde ? |
I fixed this. Update your config file https://retriever.readthedocs.io/en/latest/developer.html#passwordless-configuration |
I mean about this PR ? |
@Mohitkumar6122 the data looks fine. Always include a screenshot of the installed data. If you have setup git as recommended just like in the retriever repository, and you have upstream set up in your .git/config file as below [remote "upstream"]
url = https://github.com/weecology/retriever-recipes.git
fetch = +refs/heads/*:refs/remotes/upstream/*
fetch = +refs/pull/*/head:refs/remotes/origin/pr/* You should be able to clean up this Pr using the commands git fetch upstream
git reset --soft upstream/main # Brute Force the branch to have your changes but also be at the last commit as upstream main
Python version.py
git add -u
# check that you have only to added filed
git commit
git push origin Changes -f #force the push |
Added U.S. Department of Agriculture's PLANTS Database - The Complete PLANTS http://www.plants.usda.gov/dl_all.html dataset.
In Short, this is a solution to Issue Add Agriculture datasets from awesome-public-datasets
.
@henrykironde Could you have a look at this PR?
Thanks.