-
Notifications
You must be signed in to change notification settings - Fork 67
fix(frontend): hide reasoning steps and fix thinking overlap #844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
📝 WalkthroughWalkthroughReformats a thinking UI component and changes thinking-item filtering: SimpleThinkingView has cosmetic formatting and a container class tweak; useThinkingState now excludes all items whose Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
🧰 Additional context used📓 Path-based instructions (5)**/*.{py,ts,tsx,js,jsx}📄 CodeRabbit inference engine (AGENTS.md)
Files:
**/*.{ts,tsx}📄 CodeRabbit inference engine (AGENTS.md)
Files:
**/*.{ts,tsx,js,jsx}📄 CodeRabbit inference engine (AGENTS.md)
Files:
frontend/src/**/*.{ts,tsx}📄 CodeRabbit inference engine (AGENTS.md)
Files:
frontend/**/*.{ts,tsx,js,jsx}📄 CodeRabbit inference engine (AGENTS.md)
Files:
🧠 Learnings (3)📚 Learning: 2025-12-31T03:47:12.173ZApplied to files:
📚 Learning: 2025-12-18T02:09:09.776ZApplied to files:
📚 Learning: 2025-12-18T02:09:09.776ZApplied to files:
🧬 Code graph analysis (1)frontend/src/features/tasks/components/message/thinking/SimpleThinkingView.tsx (2)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
🔇 Additional comments (8)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
- Filter out all reasoning type thinking steps since they are displayed separately by ReasoningDisplay component - Fix overlapping issue between "Using tools" and "Thinking..." elements by changing SimpleThinkingView margin from -mb-2 to mb-3
5317f8f to
0085c24
Compare
Summary
Changes
useThinkingState.ts: Filter out allreasoningtype steps since they are already displayed byReasoningDisplaycomponentSimpleThinkingView.tsx: Change margin from-mb-2tomb-3to prevent overlap with ReasoningDisplayTest plan
Summary by CodeRabbit
Bug Fixes
Style
✏️ Tip: You can customize this high-level summary in your review settings.