-
Notifications
You must be signed in to change notification settings - Fork 26
feat(pipeline): add Next Stage button to skip stage confirmation #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
qdaxb
wants to merge
4
commits into
main
Choose a base branch
from
wegent/pipeline-next-stage-button
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
cb1422b
feat(pipeline): add Next Stage button to skip stage confirmation
qdaxb dbf440c
refactor(pipeline): reuse _create_next_stage_subtask for skip confirm…
qdaxb f0359c1
fix: address CodeRabbit review feedback
qdaxb a641b8f
chore: resolve merge conflict with main branch
qdaxb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: wecode-ai/Wegent
Length of output: 109
🏁 Script executed:
Repository: wecode-ai/Wegent
Length of output: 218
🏁 Script executed:
Repository: wecode-ai/Wegent
Length of output: 825
🏁 Script executed:
Repository: wecode-ai/Wegent
Length of output: 42
🏁 Script executed:
Repository: wecode-ai/Wegent
Length of output: 5418
🏁 Script executed:
Repository: wecode-ai/Wegent
Length of output: 146
🏁 Script executed:
Repository: wecode-ai/Wegent
Length of output: 42
🏁 Script executed:
Repository: wecode-ai/Wegent
Length of output: 42
🏁 Script executed:
Repository: wecode-ai/Wegent
Length of output: 12341
🏁 Script executed:
Repository: wecode-ai/Wegent
Length of output: 1702
🏁 Script executed:
Repository: wecode-ai/Wegent
Length of output: 1436
🏁 Script executed:
Repository: wecode-ai/Wegent
Length of output: 788
🏁 Script executed:
Repository: wecode-ai/Wegent
Length of output: 326
🏁 Script executed:
Repository: wecode-ai/Wegent
Length of output: 42
🏁 Script executed:
Repository: wecode-ai/Wegent
Length of output: 1826
🏁 Script executed:
Repository: wecode-ai/Wegent
Length of output: 42
🏁 Script executed:
Repository: wecode-ai/Wegent
Length of output: 42
🏁 Script executed:
Repository: wecode-ai/Wegent
Length of output: 1470
🏁 Script executed:
Repository: wecode-ai/Wegent
Length of output: 1190
🏁 Script executed:
Repository: wecode-ai/Wegent
Length of output: 42
🏁 Script executed:
Repository: wecode-ai/Wegent
Length of output: 1412
🏁 Script executed:
Repository: wecode-ai/Wegent
Length of output: 2227
🏁 Script executed:
Repository: wecode-ai/Wegent
Length of output: 42
🏁 Script executed:
Repository: wecode-ai/Wegent
Length of output: 761
🏁 Script executed:
Repository: wecode-ai/Wegent
Length of output: 42
🏁 Script executed:
Repository: wecode-ai/Wegent
Length of output: 4258
🏁 Script executed:
Repository: wecode-ai/Wegent
Length of output: 42
🏁 Script executed:
Repository: wecode-ai/Wegent
Length of output: 42
🏁 Script executed:
Repository: wecode-ai/Wegent
Length of output: 4182
🏁 Script executed:
Repository: wecode-ai/Wegent
Length of output: 1215
🏁 Script executed:
Repository: wecode-ai/Wegent
Length of output: 6095
🏁 Script executed:
Repository: wecode-ai/Wegent
Length of output: 1249
🏁 Script executed:
Repository: wecode-ai/Wegent
Length of output: 950
🏁 Script executed:
Repository: wecode-ai/Wegent
Length of output: 42
🏁 Script executed:
Repository: wecode-ai/Wegent
Length of output: 42
🏁 Script executed:
Repository: wecode-ai/Wegent
Length of output: 1033
🏁 Script executed:
Repository: wecode-ai/Wegent
Length of output: 42
🏁 Script executed:
Repository: wecode-ai/Wegent
Length of output: 42
🏁 Script executed:
Repository: wecode-ai/Wegent
Length of output: 42
🏁 Script executed:
Repository: wecode-ai/Wegent
Length of output: 42
🏁 Script executed:
Repository: wecode-ai/Wegent
Length of output: 286
🏁 Script executed:
Repository: wecode-ai/Wegent
Length of output: 42
🏁 Script executed:
Repository: wecode-ai/Wegent
Length of output: 449
🏁 Script executed:
Repository: wecode-ai/Wegent
Length of output: 897
🏁 Script executed:
# Check the main chat services directory structure ls -la ./backend/app/services/chat/Repository: wecode-ai/Wegent
Length of output: 902
🏁 Script executed:
Repository: wecode-ai/Wegent
Length of output: 42
🏁 Script executed:
Repository: wecode-ai/Wegent
Length of output: 42
🏁 Script executed:
Repository: wecode-ai/Wegent
Length of output: 2280
🏁 Script executed:
# Check the __init__.py in chat services to see what's exported cat ./backend/app/services/chat/__init__.pyRepository: wecode-ai/Wegent
Length of output: 952
🏁 Script executed:
Repository: wecode-ai/Wegent
Length of output: 348
🏁 Script executed:
Repository: wecode-ai/Wegent
Length of output: 42
🏁 Script executed:
Repository: wecode-ai/Wegent
Length of output: 517
🏁 Script executed:
Repository: wecode-ai/Wegent
Length of output: 42
🏁 Script executed:
Repository: wecode-ai/Wegent
Length of output: 201
🏁 Script executed:
Repository: wecode-ai/Wegent
Length of output: 1917
🏁 Script executed:
Repository: wecode-ai/Wegent
Length of output: 42
🏁 Script executed:
Repository: wecode-ai/Wegent
Length of output: 42
🏁 Script executed:
Repository: wecode-ai/Wegent
Length of output: 1077
Use a safe asyncio pattern to handle running event loops in sync context.
The
asyncio.new_event_loop()call can fail at runtime when this sync method is invoked from a FastAPI async context. Since the endpointPOST /{task_id}/skip-stage-confirmationis a sync handler running within FastAPI's async event loop, there will already be a running loop in the thread, causingasyncio.new_event_loop()to raise aRuntimeError.Instead, follow the pattern already used elsewhere in the codebase (e.g.,
knowledge_service.pylines 716-726):asyncio.get_running_loop()asyncio.run()ThreadPoolExecutorAdditionally:
int = Nonetoint | None(Python 3.10+ syntax)logger.error(f"...{str(e)}")withlogger.exception("...")to include the full stack trace for debugging🧰 Tools
🪛 Ruff (0.14.10)
851-851: PEP 484 prohibits implicit
OptionalConvert to
T | None(RUF013)
913-913: Do not catch blind exception:
Exception(BLE001)
914-914: Use
logging.exceptioninstead oflogging.errorReplace with
exception(TRY400)
914-914: Use explicit conversion flag
Replace with conversion flag
(RUF010)