fix: reparent within another slot instance #5021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kof
approved these changes
Mar 19, 2025
Ivan found a bug. Reparent slot child into another instance of the same slot got this child removed. Now refactored whole thing (almost). The main difference is same parent move will not do delete/paste but will just update child position. This fixes bug above and makes other logic slightly simpler. Rewritten reparentInstance with reparentInstanceMutable to simplify testing and make it composable (if ever need).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ivan found a bug. Reparent slot child into another instance of the same slot got this child removed.
Now refactored whole thing (almost). The main difference is same parent move will not do delete/paste but will just update child position. This fixes bug above and makes other logic slightly simpler.
Rewritten reparentInstance with reparentInstanceMutable to simplify testing and make it composable (if ever need). Added more tests.