Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Make complex values in spacing UI look good #5020

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat: Make complex values in spacing UI look good #5020

wants to merge 6 commits into from
+143 −148

Conversation

kof
Copy link
Member

@kof kof commented Mar 19, 2025 •
edited
Loading

image

Description

  1. Cuts off the long values and avoids badly looking UI
  2. Adds scroll on pointer over effect to see the value quickly

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 0000)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@kof kof marked this pull request as ready for review March 19, 2025 13:05
@kof kof requested a review from TrySound March 19, 2025 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TrySound TrySound Awaiting requested review from TrySound

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kof