Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use resettable blue label for properties #5000

Merged
merged 1 commit into from
Mar 14, 2025
Merged

feat: use resettable blue label for properties #5000

merged 1 commit into from
Mar 14, 2025

Conversation

TrySound
Copy link
Member

@TrySound TrySound commented Mar 14, 2025

Closes #4787

  • properties now have blue labels when value is specified
  • clicking on label shows tooltip
  • alt+click does reset/delete
  • responsive layout in text control now wraps when label is >30%
Screenshot 2025-03-14 at 20 25 50 Screenshot 2025-03-14 at 20 25 40

@TrySound TrySound requested review from kof and johnsicili March 14, 2025 13:26
- properties now have blue labels when value is specified
- clicking on label shows tooltip
- alt+click does reset/delete
@TrySound TrySound changed the title feat: use ressetable blue label for properties feat: use resettable blue label for properties Mar 14, 2025
Copy link
Member

@kof kof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fantastic work!

@TrySound
Copy link
Member Author

Required fields cannot be reset or deleted. I think we had the same logic before

Copy link
Contributor

@johnsicili johnsicili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! Can you make the attribute copy-able in the tooltip?

This has been a request in the past so we can easily copy at least the property (ideally property value but no way to paste right now the whole "declaration").

The tooltips in CSS allow copy, Oleg did it IIRC.

@TrySound
Copy link
Member Author

Do we have an issue about this? I would leave it for another PR.

@johnsicili
Copy link
Contributor

I guess it was only in Discord. Here's the issue #5001

@TrySound TrySound merged commit d7bb114 into main Mar 14, 2025
21 checks passed
@TrySound TrySound deleted the blue-props branch March 14, 2025 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rethink delete button in the settings/props UI
3 participants