Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Long redirects urls and paths don't shorten in the UI (#4944) #4988

Merged
merged 7 commits into from
Mar 13, 2025

Conversation

Blazing-Mike
Copy link
Contributor

Description

fix issue #4944
long redirect urls don't shorten, they extend across Project seetings container and parts of it disappears which make UI looks broken.

i added a word-break to the links, set a width for old link and max-width for the new-path link.

Screen Shot 2025-03-12 at 12 02 52 PM

Steps for reproduction

  1. click on Menu button
  2. click on "Project settings" Menu item
  3. Click on the Redirects on the sidebar
  4. Input old-path and new-path or URL
  5. Click Add

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 0000)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@Blazing-Mike Blazing-Mike changed the title Fix: Long redirects urls and paths don't shorten in the UI (#4944) fix: Long redirects urls and paths don't shorten in the UI (#4944) Mar 12, 2025
@Blazing-Mike
Copy link
Contributor Author

any details to why Lost Pixel App checks are failing, i am not familiar with the platform. does it have to do with fix from my commits? @kof

@kof kof temporarily deployed to development March 13, 2025 14:39 — with GitHub Actions Inactive
@kof kof temporarily deployed to development March 13, 2025 14:39 — with GitHub Actions Inactive
@kof kof temporarily deployed to development March 13, 2025 14:39 — with GitHub Actions Inactive
@kof kof temporarily deployed to development March 13, 2025 14:39 — with GitHub Actions Inactive
@kof kof merged commit 9442afc into webstudio-is:main Mar 13, 2025
9 of 10 checks passed
@kof
Copy link
Member

kof commented Mar 13, 2025

merged, thank you!

@kof
Copy link
Member

kof commented Mar 13, 2025

Just noticed, there is still a tooltip issue
image

I think we can just delete the tooltip because now as its full size text is rendered, we don't need a tooltip

@Blazing-Mike
Copy link
Contributor Author

Alright.would create a PR for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants