Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tolerate comma instead of dot typo in style value input #3926

Merged
merged 3 commits into from
Aug 13, 2024

Conversation

kof
Copy link
Member

@kof kof commented Aug 11, 2024

Part of #3914

Description

Users often type comma instead of dot when entering css value numbers, we want to auto convert them to dot.

Steps for reproduction

  1. type 1,2 in width input
  2. hit enter, see it was converted to 1.2
  3. type 1,2rem
  4. hit enter, see it was converted to 1.2 and rem unit was applied

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@kof kof requested a review from TrySound August 11, 2024 19:06
@kof kof merged commit f7c02b2 into main Aug 13, 2024
14 checks passed
@kof kof deleted the comma-typo-support branch August 13, 2024 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants