-
Notifications
You must be signed in to change notification settings - Fork 2
Feature -> Develop | Added Platform Channel Service #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Handing this over to @we-kislay-k001 from @we-mohd-i001 |
32100eb to
798ce11
Compare
798ce11 to
e36b22e
Compare
fd0ab60 to
38d741b
Compare
38d741b to
c99f3ab
Compare
assets/env/production.json
Outdated
| "one_signal_config": null, | ||
| "pusher_config": null, | ||
| "show_debug_panel": false, | ||
| "method_channel_name": "", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticing a difference in method_channel configurations between develop.json and production.json method_channel_map is an object in one, while method_channel_name is a string in the other. Just wanted to check if this is intentional else we should fix it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
assets/env/staging.json
Outdated
| "one_signal_config": null, | ||
| "pusher_config": null, | ||
| "show_debug_panel": true, | ||
| "method_channel_name": "", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticing a difference in method_channel configurations between develop.json and production.json method_channel_map is an object in one, while method_channel_name is a string in the other. Just wanted to check if this is intentional else we should fix it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
| /// Calls the native platform method to show a snackbar. | ||
| Future<void> _showNativeSnackbar() async { | ||
| try { | ||
| final String? result = await _platform.invokeMethod<String>('showSnackbar'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we could use a file to keep track of methods like - PlatformMethods.showSnackbar for known methods while allowing users to call any method name as a string, instead of hard-coding it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure I will find a better way instead of harcoding it.
c99f3ab to
65a2232
Compare
0bc12c3 to
57a2596
Compare
Task #28 - Platform Specific Code > Method Channel & Event Channel
Time invested: hh:mm format 18:20 | Billable: 18:20 | Non-Billable: 00:00
Problem Statement
Describe The Fix/ Solution You Implemented
I have added a service that can used to invoke methods and get event streams from the native side.
Proof of your testing (Demo link or video links or image links)
Demo
Dependencies
Updated:
Added:
Merge Request Checklist
industry standardswarnings/ errorsfordart analyzertestspass locally with my changes (No tests are there as of now)properly formattedfeatureon the latestdevelopflutter runafter the rebasecomments¬esinwireframeand verified that I did take care of thatUImust match withdesign&wireframeif availableversion/ build(x.x.x+xxx)developexists in yourfeaturebranch after rebase.