chore: upgrade eslint from v8 to v9 #568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
330
to
342
| // it('should delegate resolving (LESS) imports with URLs to "less" package', async () => { | ||
| // const testId = "./import-keyword-url.less"; | ||
| // const compiler = getCompiler(testId); | ||
| // const stats = await compile(compiler); | ||
| // const codeFromBundle = getCodeFromBundle(stats, compiler); | ||
| // const codeFromLess = await getCodeFromLess(testId); | ||
| // | ||
| // expect(codeFromBundle.css).toBe(codeFromLess.css); | ||
| // expect(codeFromBundle.css).toMatchSnapshot("css"); | ||
| // expect(getWarnings(stats)).toMatchSnapshot("warnings"); | ||
| // expect(getErrors(stats)).toMatchSnapshot("errors"); | ||
| // }); | ||
|
|
Comment on lines
684
to
705
| // it("should not add to dependencies imports with URLs", async () => { | ||
| // const testId = "./import-url-deps.less"; | ||
| // const compiler = getCompiler(testId); | ||
| // const stats = await compile(compiler); | ||
| // const codeFromBundle = getCodeFromBundle(stats, compiler); | ||
| // const codeFromLess = await getCodeFromLess(testId); | ||
| // const { fileDependencies } = stats.compilation; | ||
| // | ||
| // validateDependencies(fileDependencies); | ||
| // | ||
| // Array.from(fileDependencies).forEach((item) => { | ||
| // ["http", "https"].forEach((protocol) => { | ||
| // expect(item.includes(protocol)).toBe(false); | ||
| // }); | ||
| // }); | ||
| // | ||
| // expect(codeFromBundle.css).toBe(codeFromLess.css); | ||
| // expect(codeFromBundle.css).toMatchSnapshot("css"); | ||
| // expect(getWarnings(stats)).toMatchSnapshot("warnings"); | ||
| // expect(getErrors(stats)).toMatchSnapshot("errors"); | ||
| // }); | ||
|
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #568 +/- ##
==========================================
+ Coverage 92.02% 92.21% +0.19%
==========================================
Files 3 3
Lines 163 167 +4
Branches 41 44 +3
==========================================
+ Hits 150 154 +4
Misses 12 12
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
upgrade eslint from v8 to v9
Breaking Changes
No
Additional Info
No