Fix: Restrict pool updates to pools with registrations #3856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3856 +/- ##
==========================================
+ Coverage 82.37% 82.44% +0.06%
==========================================
Files 355 355
Lines 12542 12563 +21
==========================================
+ Hits 10332 10358 +26
+ Misses 2210 2205 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tindevw
force-pushed
the
block-pools-update-post-activation
branch
2 times, most recently
from
c042f7b to
4e5d5a0
Compare
tindevw
force-pushed
the
block-pools-update-post-activation
branch
3 times, most recently
from
39667b3 to
bb926b4
Compare
tindevw
force-pushed
the
block-pools-update-post-activation
branch
from
bb926b4 to
3fe4152
Compare
tindevw
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Blocks edits to permission groups and activation date in pools with registrations. Validation is added in the pool serializer, and event updates now delegates to it. Added tests and removed unused create method in the pool read-only serializer. It is only used for event read so it feels safe to clean up.
Testing