Skip to content

Support filtering of companies #3706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 18, 2024
Merged

Support filtering of companies #3706

merged 2 commits into from
Dec 18, 2024

Conversation

@ivarnakken
Copy link
Member

@ivarnakken ivarnakken commented Dec 18, 2024

Related webapp PR: webkom/lego-webapp#5237

@ivarnakken ivarnakken added new-feature Pull requests that introduce or issues that suggest a new feature review-needed Pull requests that need review labels Dec 18, 2024
@ivarnakken ivarnakken requested a review from a team December 18, 2024 12:00
@ivarnakken ivarnakken self-assigned this Dec 18, 2024
@linear
Copy link

linear bot commented Dec 18, 2024

ABA-1203 Implement filtering on /companies

@ivarnakken ivarnakken requested a review from norbye December 18, 2024 12:01
@ivarnakken ivarnakken mentioned this pull request Dec 18, 2024
Merged
4 tasks
@ivarnakken ivarnakken force-pushed the ivarnakken/aba-1203-implement-filtering-on-companies branch from ec003e6 to 95a6183 Compare December 18, 2024 12:02
@codecov
Copy link

codecov bot commented Dec 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 98.11321% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.62%. Comparing base (b8247bb) to head (fdd9acc).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
lego/apps/companies/filters.py 93.75% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3706      +/-   ##
==========================================
+ Coverage   89.60%   89.62%   +0.01%     
==========================================
  Files         700      701       +1     
  Lines       22420    22471      +51     
==========================================
+ Hits        20090    20140      +50     
- Misses       2330     2331       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ivarnakken ivarnakken force-pushed the ivarnakken/aba-1203-implement-filtering-on-companies branch from 071a33b to fdd9acc Compare December 18, 2024 13:53
@ivarnakken ivarnakken added the tests Pull requests that add or update tests label Dec 18, 2024
norbye
norbye approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@norbye norbye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ivarnakken ivarnakken merged commit 2a193dd into master Dec 18, 2024
1 check passed
@ivarnakken ivarnakken deleted the ivarnakken/aba-1203-implement-filtering-on-companies branch December 18, 2024 14:05
@ivarnakken ivarnakken added the approved Pull requests that have been approved label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@norbye norbye norbye approved these changes

Assignees

@ivarnakken ivarnakken

Labels

approved Pull requests that have been approved new-feature Pull requests that introduce or issues that suggest a new feature review-needed Pull requests that need review tests Pull requests that add or update tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ivarnakken @norbye