Updated toPascalCase() to better handle uppercase words
#211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the toPascalCase() function to properly preserve uppercase words (like "DLQ" or "UPPERCASE") when converting strings to PascalCase format. The implementation optimizes type checking by replacing a custom getType() call with a native typeof operator, and updates project dependencies including pnpm, TypeScript, and various development tools.
- Added regex pattern to detect and preserve consecutive uppercase letters
- Replaced custom type check with native
typeofoperator - Updated development dependencies to latest versions
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/toPascalCase.test.ts | Added test cases to verify uppercase word handling (DLQ, UPPERCASE words, mixed alphanumeric) |
| src/toPascalCase.ts | Updated regex pattern to capture uppercase sequences and simplified type checking logic |
| package.json | Updated pnpm package manager and multiple dev dependencies to newer versions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
🎉 This PR is included in version 0.74.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
toPascalCase()to better handle uppercase wordspnpmversion