Improved DeepPartial
#209
Merged
Improved DeepPartial
#209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull Request Overview
This PR improves the DeepPartial type utility to handle arrays correctly and adds a new byRandom sorting utility. The main change enhances the type system's ability to recursively make array elements partial while maintaining proper type safety.
- Enhanced
DeepPartialtype to properly handle arrays by making array elements partial recursively - Added new
byRandomsorting function with cryptographically secure random number generation - Updated package dependencies to latest versions
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/types/utils.ts | Enhanced DeepPartial type to handle arrays by adding array-specific case before object handling |
| src/sort/byRandom.ts | New sorting utility that returns random comparison values using crypto.getRandomValues with bias avoidance |
| test/types/utils.test-d.ts | Added comprehensive type tests for DeepPartial covering objects, primitives, and arrays |
| test/sort/byRandom.test.ts | Added unit tests for byRandom function covering return values and array shuffling |
| package.json | Updated package manager and multiple dev dependencies to latest versions |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
🎉 This PR is included in version 0.73.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.