Moved sort functions #207
Merged
Moved sort functions #207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request reorganizes sort functions from a flat structure into a hierarchical directory structure. The sort functions are moved from single files into categorized subdirectories, and test files are restructured to match the new organization.
- Moves sort comparison functions to individual files in
src/sort/directory - Extracts factory functions to
src/sort/factory/subdirectory - Updates test files to match the new directory structure
- Adds a new
nullishpredicate factory function with corresponding test
Reviewed Changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/sort/factory/byReverseOf.test.ts | New test file for byReverseOf factory function |
| test/sort/factory/byProperty.test.ts | Updated imports and removed byReverseOf tests (moved to separate file) |
| test/sort/byTimestamp.test.ts | New test file for byTimestamp function |
| test/sort/bySubtraction.test.ts | New test file for bySubtraction function |
| test/sort/bySimpleComparison.test.ts | New test file for bySimpleComparison function |
| test/sort/byLocaleCompare.test.ts | New test file for byLocaleCompare function |
| test/sort.test.ts | Removed (tests moved to individual files) |
| test/predicate/factory/nullish.test.ts | New test file for nullish predicate factory |
| src/types/common.ts | Added Nullish type definition |
| src/sort/factory/byReverseOf.ts | New file for byReverseOf factory function |
| src/sort/factory/byProperty.ts | Updated imports and removed byReverseOf (moved to separate file) |
| src/sort/byTimestamp.ts | New file for byTimestamp function |
| src/sort/bySubtraction.ts | New file for bySubtraction function |
| src/sort/bySimpleComparison.ts | New file for bySimpleComparison function |
| src/sort/byLocaleCompare.ts | New file for byLocaleCompare function |
| src/sort.ts | Removed (functions moved to individual files) |
| src/predicate/factory/nullish.ts | New predicate factory function |
| src/predicate/factory/index.ts | Added export for nullish function |
| src/index.ts | Removed exports for sort modules |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
🎉 This PR is included in version 0.72.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.