Adjust usage of passHref on links

webdevcody · Oct 23, 2024 · 12b8e4e · 12b8e4e
1 parent 6cfb0d5
commit 12b8e4e
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 10 deletions.
diff --git a/app/header.tsx b/app/header.tsx
@@ -44,7 +44,7 @@ export default function Header() {
 
   return (
     <header className="flex items-center justify-between border-b px-6 py-4 shadow-sm">
-      <Link href="/" className="flex items-center">
+      <Link href="/" className="flex items-center" passHref>
         <Image src="/logo.png" alt="Logo" width={32} height={32} priority />
         <span className="ml-2 text-xl font-bold">SurviveTheNight</span>
       </Link>
@@ -89,6 +89,7 @@ export default function Header() {
           target="_blank"
           rel="noopener noreferrer"
           className="flex items-center gap-2 text-sm"
+          passHref
         >
           Synced using Convex
           <Image src="/convex.svg" alt="Convex" width={24} height={24} />
@@ -108,6 +109,7 @@ export default function Header() {
             href="https://github.com/webdevcody/survive-the-night-sim"
             rel="noopener noreferrer"
             target="_blank"
+            passHref
           >
             <GitHubLogoIcon className="h-4 w-4" />
           </Link>

diff --git a/app/play/[level]/[attempt]/page.tsx b/app/play/[level]/[attempt]/page.tsx
@@ -31,7 +31,7 @@ export default function PlayLevelAttemptPage({
     <div className="container mx-auto flex min-h-screen flex-col items-center gap-8 py-12 pb-24">
       <div className="flex w-full items-center justify-between">
         <Button variant="outline" asChild className="flex items-center gap-2">
-          <Link href={`/play/${level}`}>
+          <Link href={`/play/${level}`} passHref>
             <ChevronLeftIcon /> Back To Night #{level}
           </Link>
         </Button>

diff --git a/app/play/[level]/page.tsx b/app/play/[level]/page.tsx
@@ -57,9 +57,7 @@ export default function PlayLevelPage({
             </Link>
           </Button>
           <Button variant="outline" asChild className="flex items-center gap-2">
-            <Link href="/rules" passHref>
-              Rules
-            </Link>
+            <Link href="/rules">Rules</Link>
           </Button>
           {flags?.showTestPage && (
             <Tabs
@@ -166,9 +164,7 @@ export default function PlayLevelPage({
           </Link>
         </Button>
         <Button variant="outline" asChild className="flex items-center gap-2">
-          <Link href="/rules" passHref>
-            Rules
-          </Link>
+          <Link href="/rules">Rules</Link>
         </Button>
         {flags?.showTestPage && (
           <Tabs

diff --git a/app/prompts/[promptId]/page.tsx b/app/prompts/[promptId]/page.tsx
@@ -61,7 +61,7 @@ export default function EditPromptPage({
           <h1 className="mb-4 font-semibold">Edit your prompt</h1>
           <div className="flex space-x-4">
             <Button variant="default">Save</Button>
-            <Link href="/prompts">
+            <Link href="/prompts" passHref>
               <Button variant="default">Return</Button>
             </Link>
           </div>

diff --git a/app/prompts/page.tsx b/app/prompts/page.tsx
@@ -72,6 +72,7 @@ export default function PromptsPage() {
                   <Link
                     href={`/prompts/${row._id}`}
                     className="flex items-center"
+                    passHref
                   >
                     <Button variant="secondary">Edit</Button>
                   </Link>

diff --git a/components/PlayMapButton.tsx b/components/PlayMapButton.tsx
@@ -8,7 +8,7 @@ import { Button } from "./ui/button";
 export function PlayMapButton({ mapId }: { mapId: string }) {
   return (
     <Button asChild variant="outline" size="icon">
-      <Link href={`/playground?map=${mapId}`}>
+      <Link href={`/playground?map=${mapId}`} passHref>
         <ExternalLinkIcon size={16} />
       </Link>
     </Button>