Skip to content

initial port to fabric 1.21.5 #4200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: v3.0
Choose a base branch
from

Conversation

petersv5
Copy link

@petersv5 petersv5 commented Apr 5, 2025

This port was inspired by the #4198 port for spigot 1.21.5 for the NBT updates. Like that it also does not implement the new blocks.

Only light testing has been done, but it seems to work just as under 1.21.4 so far.

Note that gradle had to be updated to 8.12.

This port was inspired by the webbukkit#4198 port for spigot 1.21.5 for the
NBT updates. Like that it also does not implement the new blocks.

Only light testing has been done, but it seems to work just as under
1.21.4 so far.

Note that gradle had to be updated to 8.12.
@PaladinLaw
Copy link

Built this myself, have been running it a couple of hours now and have not had any issues. Thank you very much @petersv5! At least I can have my map back temporarily until an official version is released

@NickPetrone
Copy link

I'm having a lot of trouble building the jar. Don't suppose someone could post it? Thanks

@PaladinLaw
Copy link

PaladinLaw commented Apr 9, 2025

@NickPetrone trusting random jars (and / or files for that matter) from strangers on the internet is brave...

That said, have fun mate.

Dynmap-3.7-SNAPSHOT-fabric-1.21.5.zip

No guarantees and / or liabilities obviously as all I did was build from this PR 😁

@NickPetrone
Copy link

@PaladinLaw I appreciate the warning, but I already planned on comparing it to the 1.21.4 jar to ensure there were no shenanigans haha. Thanks so much, working great!

@ricardoponcio
Copy link

Here it worked!
Only a comment, by default my dynmap/ root folder was created as user 0 so i didn't have the right permissions, the error is not so clear:

java.lang.NullPointerException: null
        at java.base/java.io.File.<init>(Unknown Source) ~[?:?]
        at knot/org.dynmap.DynmapCore.combinePaths(DynmapCore.java:1142) ~[Dynmap-3.7-SNAPSHOT-fabric-1.21.5.jar:?]
        at knot/org.dynmap.DynmapCore.getFile(DynmapCore.java:1152) ~[Dynmap-3.7-SNAPSHOT-fabric-1.21.5.jar:?]
        at knot/org.dynmap.DynmapCore.updateExtractedFiles(DynmapCore.java:2914) ~[Dynmap-3.7-SNAPSHOT-fabric-1.21.5.jar:?]

Also in crashreport:

java.lang.NullPointerException: Exception in server tick loop
        at java.base/java.io.File.<init>(Unknown Source)
        at knot//org.dynmap.DynmapCore.combinePaths(DynmapCore.java:1142)
        at knot//org.dynmap.DynmapCore.getFile(DynmapCore.java:1152)
        at knot//org.dynmap.DynmapCore.updateExtractedFiles(DynmapCore.java:2914)

But after a chmod worked like a charm.
I hope that the contributor didn't insert anything that can be a problem 🙈

@Zitchas
Copy link

Zitchas commented Apr 26, 2025

Thanks for sharing that build. I don't have things setup to build it myself yet.

That being said, I pointed my local virus scanner at it, as well pointing VirusTotal at the zip file, and it doesn't seem to have a problem with it so far.
As an additional measure of verification for random internet people.. https://www.virustotal.com/gui/url/1ea7af9264f2253c5df01b187080f257be3ef083a3695b732cbe95361c256d65?nocache=1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants