Skip to content

Fix/windows10 wgc border crash #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
webadderall merged 2 commits into from
Mar 20, 2026
+6 −1
Merged

Fix/windows10 wgc border crash #82

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39343a3
Handle unsupported IsBorderRequired on Windows 10 causing Native Wind…
VoidGravity Mar 20, 2026
e6373f7
capturing silently, removing usless noisy warning
VoidGravity Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion electron/native/wgc-capture/src/wgc_session.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,12 @@ bool WgcSession::initializeWithItem(int fps) {
session_ = framePool_.CreateCaptureSession(captureItem_);

session_.IsCursorCaptureEnabled(false);
session_.IsBorderRequired(false);

// IsBorderRequired is only available on Windows 11+ (build 22000). propagating an hresult_error results in Native Windows capture failure
try {
session_.IsBorderRequired(false);
} catch (winrt::hresult_error const& e) {
}

return true;
}
Expand Down