Update greeter contract for modern solc #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
How come the event and newGreeting method have been removed? |
Author
|
That was a mistake. Thank you for catching it. I will push another update. |
conor10
reviewed
Dec 21, 2018
Contributor
conor10
left a comment
conor10
left a comment
There was a problem hiding this comment.
See comment re: memory declaration.
| /* this runs when the contract is executed */ | ||
| constructor (string _greeting) public { | ||
| /* This runs when the contract is executed */ | ||
| constructor(string memory _greeting) public { |
Contributor
There was a problem hiding this comment.
what was the reason for adding the memory declaration to strings? As function parameters is this not already implicit? I'd like to keep the code as simple as possible for users unfamiliar to Solidity, so I'd rather keep the memory declaration out if we can.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greeter.sol has been updated to remove compiler errors in 0.5.0.