Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monobean PGP key generation #880

Merged
merged 11 commits into from
Mar 6, 2025
Merged

Monobean PGP key generation #880

merged 11 commits into from
Mar 6, 2025

Conversation

yyk808
Copy link
Contributor

@yyk808 yyk808 commented Mar 6, 2025

Major changes

  • Add pgp key generation and management in vault::pgp
  • Related monobean ui

Fix

  • event loop stuck when handling time consuming tasks
  • user email entry regex

Screenshots

PixPin_2025-03-06_10-49-52
PixPin_2025-03-06_10-49-59
PixPin_2025-03-06_10-52-35

closing #870 (comment)

Copy link

vercel bot commented Mar 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mega ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 6, 2025 9:28am

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR introduces PGP key generation and management into the vault module and integrates it with the Monobean UI while addressing an event loop hang and regex validation issues. Key changes include:

  • New functions for PGP key generation, loading, saving, and deletion in vault/src/pgp.rs.
  • UI updates in Monobean (hello_page and window) to reflect PGP key generation status and enhanced email validation.
  • Core refactoring in MegaCore and related modules to handle asynchronous operations and improve error handling.

Reviewed Changes

File Description
vault/src/pgp.rs Adds PGP key generation and management functions.
monobean/src/components/hello_page.rs Updates UI events and regex validation for email and PGP status.
monobean/src/window.rs Adjusts page navigation and settings binding to include PGP flag.
monobean/Cargo.toml Adds vault dependency and profile improvements.
monobean/src/application.rs Updates async command handling and logging setup.
monobean/src/core/mega_core.rs Refactors core command processing and shutdown behavior.
monobean/src/core/delegate.rs Modifies delegate command sending to async and blocking variants.
monobean/src/main.rs Reorders module definitions.
vault/src/vault.rs Adds delete_api function and related changes for secret deletion.
monobean/src/core/servers.rs Adjusts SSH/HTTP options for correct type handling.
vault/Cargo.toml Introduces pgp and smallvec dependencies.
monobean/src/components/theme_selector.rs Minor cleanup in CSS resource loading.

Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.

@genedna genedna added this pull request to the merge queue Mar 6, 2025
Merged via the queue into web3infra-foundation:main with commit 51e3844 Mar 6, 2025
15 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client decentralized r2cn rust Pull requests that update Rust code
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants