Skip to content

Revert "QuotaExceededError: Update to a DOMException derived interface" #52571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2025
Merged

Revert "QuotaExceededError: Update to a DOMException derived interface" #52571

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions resources/testharness.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2321,6 +2321,7 @@
NetworkError: 19,
AbortError: 20,
URLMismatchError: 21,
QuotaExceededError: 22,
TimeoutError: 23,
InvalidNodeTypeError: 24,
DataCloneError: 25,
Expand All @@ -2335,8 +2336,7 @@
VersionError: 0,
OperationError: 0,
NotAllowedError: 0,
OptOutError: 0,
QuotaExceededError: 0
OptOutError: 0
};

var code_name_map = {};
Expand Down
7 changes: 2 additions & 5 deletions storage/buckets/bucket-quota-indexeddb.tentative.https.any.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,8 @@ promise_test(async t => {
type: 'binary/random'
}), 2);

try {
await transactionPromise(txn);
} catch (e) {
assert_equals(e.name, 'QuotaExceededError');
}
await promise_rejects_dom(
t, 'QuotaExceededError', transactionPromise(txn));

db.close();
}, 'IDB respects bucket quota');
5 changes: 2 additions & 3 deletions webidl/ecmascript-binding/es-exceptions/DOMException-constructor-behavior.any.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@ test(function() {
{name: "NetworkError", code: 19},
{name: "AbortError", code: 20},
{name: "URLMismatchError", code: 21},
{name: "QuotaExceededError", code: 22},
{name: "TimeoutError", code: 23},
{name: "InvalidNodeTypeError", code: 24},
{name: "DataCloneError", code: 25},
Expand All @@ -127,9 +128,7 @@ test(function() {
{name: "ReadOnlyError", code: 0},
{name: "VersionError", code: 0},
{name: "OperationError", code: 0},
{name: "NotAllowedError", code: 0},
// See https://github.com/whatwg/webidl/pull/1465.
{name: "QuotaExceededError", code: 0}
{name: "NotAllowedError", code: 0}
].forEach(function(test_case) {
test(function() {
var ex = new DOMException("msg", test_case.name);
Expand Down
Loading