[wdspec] Align aborted navigation tests with specification #48751
Conversation
wpt-pr-bot
requested review from
AutomatedTester,
jgraham,
juliandescottes,
shs96c and
whimboo
| async def test_interactive_change_location_throws(bidi_session, inline, | ||
| new_tab): | ||
| new_url = inline("<div>foo</div>") | ||
| url_with_redirect = inline(f"<script>window.location='{new_url}';</script>") | ||
| with pytest.raises(error.UnknownErrorException): | ||
| await bidi_session.browsing_context.navigate( | ||
| context=new_tab["context"], url=url_with_redirect, | ||
| wait="interactive") | ||
|
|
||
|
|
||
| async def test_interactive_change_location_succeeded(bidi_session, inline, | ||
| new_tab): | ||
| new_url = inline("<div>foo</div>") | ||
| url_with_redirect = inline(f"<script>window.location='{new_url}';</script>") | ||
| result = await bidi_session.browsing_context.navigate( | ||
| context=new_tab["context"], url=url_with_redirect, wait="interactive") | ||
|
|
||
| any_string(result["navigation"]) | ||
| assert result["url"] == new_url |
There was a problem hiding this comment.
By definition, one of the two tests will necessarily fail. Given that both chrome and firefox pass test_interactive_change_location_throws at the moment, maybe we should only keep this one and updated when the spec is clarified?
sadym-chromium
force-pushed
the
sadym/test_browsingContext_navigateWaitInteractive_redirect
branch
from
f56cce3 to
d9f3ac1
Compare
sadym-chromium
changed the title
There was a problem hiding this comment.
I was looking at the two similar tests in bidi/browsing_context/navigation_failed/navigation_failed.py, at the moment they expect a navigationFailed event for similar scenarios. If I understand the spec change correctly, this also wrong? Can you check if they need updating?
I'm working on it from the implementation side: GoogleChromeLabs/chromium-bidi#2856 |
Does this mean you will also update those tests here or will it be another PR? |
|
closing in favor of #49718 |
Align aborted navigation tests with specification.
WebDriver BiDi requires to succeed the navigation, if it was aborted by another navigation:
browsingContext.navigatebrowsingContext.navigationAbortedevent).