[Credentialless] Fix flakes about iframeTest.js #29265
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 7, 2021
In the various tests, there are up to 8 <iframe> navigating concurrently. There are no ways to detect an <iframe> fails to load other than using a timeout. See whatwg/html#125. The 3000ms timeout was sometimes too short. This cause flakes. To reduce the rate of false positive, the timeout has been increased to 6000ms. R: [email protected] CC: [email protected] Fixed: 1215956 Bug: 1175099 Change-Id: I7bedccb351ff62d55b6020403aac5457608e5497 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2944929 Reviewed-by: Titouan Rigoudy <[email protected]> Commit-Queue: Arthur Sonzogni <[email protected]> Cr-Commit-Position: refs/heads/master@{#890171}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2944929
branch
from
8787b74 to
78b0123
Compare
|
The origin CL has been reverted. Closing this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the various tests, there are up to 8 <iframe> navigating concurrently.
There are no ways to detect an <iframe> fails to load other than using
a timeout. See whatwg/html#125.
The 3000ms timeout was sometimes too short. This cause flakes.
To reduce the rate of false positive, the timeout has been increased to
6000ms.
R: [email protected]
CC: [email protected]
Fixed: 1215956
Bug: 1175099
Change-Id: I7bedccb351ff62d55b6020403aac5457608e5497
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2944929
Reviewed-by: Titouan Rigoudy <[email protected]>
Commit-Queue: Arthur Sonzogni <[email protected]>
Cr-Commit-Position: refs/heads/master@{#890171}
Revert "[Credentialless] Fix flakes about iframeTest.js"
This reverts commit cad80cd16f74475116e60b568f0fce785fb50f99.
Reason for revert: crbug.com/1217587
Bug: 1175099
Change-Id: I258c8e9219c708f22e6d14d2648e6e588a410b99
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2944393
Owners-Override: Saurabh Nijhara [email protected]
Bot-Commit: Rubber Stamper [email protected]
Commit-Queue: Saurabh Nijhara [email protected]
Cr-Commit-Position: refs/heads/master@{#890202}