[wdspec] Add tests for proposed full page screen endpoint #26652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is to add tests using GET screenshot/full for WebDriver
proposed at [1]. The tests are copied from take_screenshot/ and
modified to use the full page screenshot endpoint. In iframe.py
test_source_origin test, the cross origin test full page screenshot
does not generate the same png as the same origin one. This behavior
has been verified by taking the full page screenshot in browser
DevTools directly using Capture full size screenshot[2].
Added a function to get full page dimensions using
document.scrollingElement.scroll{Width,Height}.
[1] w3c/webdriver#1536
[2] https://www.deconetwork.com/blog/how-to-take-full-webpage-screenshots-instantly/#:~:text=Click%20Command%2BShift%2BP%20on,Select%20Capture%20full%20size%20screenshot.
Add a large div element so that the page does not fit in viewport and test full page screenshot capture the entire page.
wpt-pr-bot
requested review from
AutomatedTester,
andreastt,
mjzffr,
shs96c and
whimboo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed a new endpoint /screenshot/full to capture full page screenshot in [1]
Copied and modified tests from webdriver/tests/take_screenshot and added one more test for a large page.
In iframe.py test_source_origin, deleted the last comparison between reference_screenshot and screenshot because
they are not the same for full page screenshot(reason unknown to me). The behavior is verified using Chrome DevTools to take full page screenshot directly. Images are the same if taking regular screenshot but different taking full page screenshot. @whimboo Any ideas?
[1] w3c/webdriver#1536