[css-values] Add tests for basic min() / max() support #19819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://drafts.csswg.org/css-values-4/#functional-notations Tests cover the following: - attr() in max() - calc() in max() - max() with 20 arguments - min() with unitless 0
wpt-pr-bot
requested review from
dbaron,
fantasai,
FremyCompany,
frivoal,
plinss and
tabatkins
foolip
reviewed
Oct 22, 2019
css/css-values/attr-in-max.html
Outdated
| <html> | ||
| <head> | ||
| <meta charset="utf-8"> | ||
| <title> |
There was a problem hiding this comment.
@foolip Just pushed a commit to compact the markup. Thanks!
foolip
reviewed
Oct 22, 2019
| <link rel="match" href="reference/all-green.html"> | ||
|
|
||
| <style> | ||
| html, body { margin: 0px; padding: 0px; } |
There was a problem hiding this comment.
This is indented very deeply. It's probably best to replace tabs with spaces so that we're all seeing the same thing, since tabs can be any number of spaces...
|
I pushed a commit which I think will make the lint on Taskcluster pass. I'm not a good reviewer for the tests themselves. @xfq if you don't get a reaction, you'll need to go poking people for review directly. @astearns FYI that reviews aren't working very well, although that's true of almost all of wpt, not just the css directory. |
astearns
approved these changes
Oct 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resubmitted from #19801. Original description: