Also check mergeable_state to identify draft pull requests
#108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This field can currently be observed here: https://api.github.com/repos/web-platform-tests/wpt/pulls/19806 There's no stability guarantee here, it's a quickfix. Fixes #69.
foolip
commented
Oct 25, 2019
| @@ -21,7 +21,11 @@ function filterPullRequest(pull_request, log) { | |||
| log(`Ignoring #${pull_request.number}: pull request is closed`); | |||
| return false; | |||
| } | |||
| if (pull_request.draft) { | |||
| // Note: the `draft` boolean is a preview API which we don't enable: | |||
There was a problem hiding this comment.
The reasoning for keeping this even though it doesn't work now is that it'll start working by default soon enough. If mergeable_state goes away after that this won't break. It might still break before then of course, but quickfix :)
zcorpan
approved these changes
Oct 25, 2019
There was a problem hiding this comment.
Looks ok, but would be good to have @jugglinmike take a look also
jugglinmike
approved these changes
Oct 26, 2019
|
I'll merge and test this now. |
|
This is deployed, tested in web-platform-tests/wpt#19959 - it seems to work. Leaving that draft PR open for now if you want to test something more. |
|
Seems to work, finally :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This field can currently be observed here:
https://api.github.com/repos/web-platform-tests/wpt/pulls/19806
There's no stability guarantee here, it's a quickfix.
Fixes #69.