Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do nothing with draft PRs #69

Closed
foolip opened this issue Feb 27, 2019 · 19 comments · Fixed by #86 or #108
Closed

Do nothing with draft PRs #69

foolip opened this issue Feb 27, 2019 · 19 comments · Fixed by #86 or #108

Comments

@foolip
Copy link
Member

foolip commented Feb 27, 2019

web-platform-tests/wpt#15561 is a draft PR, a new GitHub feature. The bot shouldn't assign reviewers to such PRs. https://api.github.com/repos/web-platform-tests/wpt/pulls/15561 says "mergeable_state": "draft" so that must be how to handle it. I don't know what webhook is triggered when that state changes though.
@foolip foolip mentioned this issue Feb 27, 2019
Merged
3 tasks
@foolip
Copy link
Member Author

foolip commented Aug 15, 2019

Fixed by #73.

@foolip foolip closed this as completed Aug 15, 2019
@foolip
Copy link
Member Author

foolip commented Aug 17, 2019

Nope, that didn't work. web-platform-tests/wpt#18519 is draft and the bot bothered @jgraham on it.

@jugglinmike can you check it out?

@foolip foolip reopened this Aug 17, 2019
@jugglinmike
Copy link
Contributor

@foolip Should the bot assign labels to draft pull requests?

@foolip
Copy link
Member Author

foolip commented Aug 24, 2019

@jugglinmike I don't think that matters much, but I'd say no. Doing nothing at all is simple to understand and doesn't require testing of what is and isn't done.

@jugglinmike
Copy link
Contributor

gh-78 has uncovered an edge case we'll want to account for: if we don't assign a reviewer immediately, there is a chance that the pull request author will review their own work, and when the pull request leaves the "draft" state, the author will be assigned.

@jugglinmike jugglinmike mentioned this issue Aug 27, 2019
Open
@zcorpan
Copy link
Member

zcorpan commented Oct 4, 2019

In web-platform-tests/wpt#19514 it looks like the bot did stuff after the first comment was posted.

foolip added a commit that referenced this issue Oct 18, 2019
@foolip
Do nothing with draft PRs
8c80e9d 
Fixes #69.
@foolip foolip mentioned this issue Oct 18, 2019
Closed
@foolip
Copy link
Member Author

foolip commented Oct 18, 2019

Trying another fix in #80.

@foolip foolip mentioned this issue Oct 18, 2019
Merged
@foolip
Copy link
Member Author

foolip commented Oct 20, 2019

#38 is related.

@foolip foolip mentioned this issue Oct 20, 2019
Closed
foolip added a commit that referenced this issue Oct 21, 2019
@foolip
Extract event and pull request filtering and attempt to make robust
b01ad36 
This is not plain refactoring, as the `state == "closed"` condition
replaces the check on `merged`. It also ensures that we perform the
same checks both on the event payload and on the response from
https://developer.github.com/v3/pulls/#get-a-single-pull-request.

Fixes #38.
Fixes #69.
@foolip foolip mentioned this issue Oct 21, 2019
Merged
foolip added a commit that referenced this issue Oct 21, 2019
@foolip
Extract event and pull request filtering and attempt to make robust
5325ed7 
This is not plain refactoring, as the `state == "closed"` condition
replaces the check on `merged`. It also ensures that we perform the
same checks both on the event payload and on the response from
https://developer.github.com/v3/pulls/#get-a-single-pull-request.

Fixes #38.
Fixes #69.
foolip added a commit that referenced this issue Oct 21, 2019
@foolip
Extract event and pull request filtering and attempt to make robust
ac91c90 
This is not plain refactoring, as the `state == "closed"` condition
replaces the check on `merged`. It also ensures that we perform the
same checks both on the event payload and on the response from
https://developer.github.com/v3/pulls/#get-a-single-pull-request.

Fixes #38.
Fixes #69.
jugglinmike pushed a commit that referenced this issue Oct 23, 2019
@foolip @jugglinmike
Extract event and pull request filtering and attempt to make robust
5b5b4f7 
This is not plain refactoring, as the `state == "closed"` condition
replaces the check on `merged`. It also ensures that we perform the
same checks both on the event payload and on the response from
https://developer.github.com/v3/pulls/#get-a-single-pull-request.

Fixes #38.
Fixes #69.
@foolip foolip mentioned this issue Oct 25, 2019
Closed
@foolip
Copy link
Member Author

foolip commented Oct 25, 2019

web-platform-tests/wpt#19879 shows that this still isn't working.

@foolip foolip reopened this Oct 25, 2019
@foolip
Copy link
Member Author

foolip commented Oct 25, 2019 •
edited
Loading

It looks like it's commenting gets past the filters. The webhook I think triggered the bot on web-platform-tests/wpt#19879 was:

Headers

Request URL: https://wpt-pr-bot.herokuapp.com/github-hook
Request method: POST
content-type: application/json
Expect: 
User-Agent: GitHub-Hookshot/c22ab44
X-GitHub-Delivery: 27bae380-f704-11e9-953c-c88897326471
X-GitHub-Event: issue_comment
X-Hub-Signature: [redacted]

Payload

{
  "action": "created",
  "issue": {
    "url": "https://api.github.com/repos/web-platform-tests/wpt/issues/19879",
    "repository_url": "https://api.github.com/repos/web-platform-tests/wpt",
    "labels_url": "https://api.github.com/repos/web-platform-tests/wpt/issues/19879/labels{/name}",
    "comments_url": "https://api.github.com/repos/web-platform-tests/wpt/issues/19879/comments",
    "events_url": "https://api.github.com/repos/web-platform-tests/wpt/issues/19879/events",
    "html_url": "https://github.com/web-platform-tests/wpt/pull/19879",
    "id": 512376735,
    "node_id": "MDExOlB1bGxSZXF1ZXN0MzMyMzk4MzY1",
    "number": 19879,
    "title": "[infra] remove the top-level wpt.py",
    "user": {
      "login": "foolip",
      "id": 498917,
      "node_id": "MDQ6VXNlcjQ5ODkxNw==",
      "avatar_url": "https://avatars1.githubusercontent.com/u/498917?v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/foolip",
      "html_url": "https://github.com/foolip",
      "followers_url": "https://api.github.com/users/foolip/followers",
      "following_url": "https://api.github.com/users/foolip/following{/other_user}",
      "gists_url": "https://api.github.com/users/foolip/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/foolip/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/foolip/subscriptions",
      "organizations_url": "https://api.github.com/users/foolip/orgs",
      "repos_url": "https://api.github.com/users/foolip/repos",
      "events_url": "https://api.github.com/users/foolip/events{/privacy}",
      "received_events_url": "https://api.github.com/users/foolip/received_events",
      "type": "User",
      "site_admin": false
    },
    "labels": [

    ],
    "state": "open",
    "locked": false,
    "assignee": null,
    "assignees": [

    ],
    "milestone": null,
    "comments": 0,
    "created_at": "2019-10-25T08:28:32Z",
    "updated_at": "2019-10-25T08:48:03Z",
    "closed_at": null,
    "author_association": "CONTRIBUTOR",
    "pull_request": {
      "url": "https://api.github.com/repos/web-platform-tests/wpt/pulls/19879",
      "html_url": "https://github.com/web-platform-tests/wpt/pull/19879",
      "diff_url": "https://github.com/web-platform-tests/wpt/pull/19879.diff",
      "patch_url": "https://github.com/web-platform-tests/wpt/pull/19879.patch"
    },
    "body": ""
  },
  "comment": {
    "url": "https://api.github.com/repos/web-platform-tests/wpt/issues/comments/546263939",
    "html_url": "https://github.com/web-platform-tests/wpt/pull/19879#issuecomment-546263939",
    "issue_url": "https://api.github.com/repos/web-platform-tests/wpt/issues/19879",
    "id": 546263939,
    "node_id": "MDEyOklzc3VlQ29tbWVudDU0NjI2MzkzOQ==",
    "user": {
      "login": "foolip",
      "id": 498917,
      "node_id": "MDQ6VXNlcjQ5ODkxNw==",
      "avatar_url": "https://avatars1.githubusercontent.com/u/498917?v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/foolip",
      "html_url": "https://github.com/foolip",
      "followers_url": "https://api.github.com/users/foolip/followers",
      "following_url": "https://api.github.com/users/foolip/following{/other_user}",
      "gists_url": "https://api.github.com/users/foolip/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/foolip/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/foolip/subscriptions",
      "organizations_url": "https://api.github.com/users/foolip/orgs",
      "repos_url": "https://api.github.com/users/foolip/repos",
      "events_url": "https://api.github.com/users/foolip/events{/privacy}",
      "received_events_url": "https://api.github.com/users/foolip/received_events",
      "type": "User",
      "site_admin": false
    },
    "created_at": "2019-10-25T08:48:03Z",
    "updated_at": "2019-10-25T08:48:03Z",
    "author_association": "CONTRIBUTOR",
    "body": "This was added in https://github.com/web-platform-tests/wpt/pull/6907 to allow `python wpt <command>` to work on Windows. This is draft until I've worked out if removing it would have any impact on anyone. If it does it's not worth the cleanup."
  },
  "repository": {
    "id": 3618133,
    "node_id": "MDEwOlJlcG9zaXRvcnkzNjE4MTMz",
    "name": "wpt",
    "full_name": "web-platform-tests/wpt",
    "private": false,
    "owner": {
      "login": "web-platform-tests",
      "id": 37226233,
      "node_id": "MDEyOk9yZ2FuaXphdGlvbjM3MjI2MjMz",
      "avatar_url": "https://avatars0.githubusercontent.com/u/37226233?v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/web-platform-tests",
      "html_url": "https://github.com/web-platform-tests",
      "followers_url": "https://api.github.com/users/web-platform-tests/followers",
      "following_url": "https://api.github.com/users/web-platform-tests/following{/other_user}",
      "gists_url": "https://api.github.com/users/web-platform-tests/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/web-platform-tests/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/web-platform-tests/subscriptions",
      "organizations_url": "https://api.github.com/users/web-platform-tests/orgs",
      "repos_url": "https://api.github.com/users/web-platform-tests/repos",
      "events_url": "https://api.github.com/users/web-platform-tests/events{/privacy}",
      "received_events_url": "https://api.github.com/users/web-platform-tests/received_events",
      "type": "Organization",
      "site_admin": false
    },
    "html_url": "https://github.com/web-platform-tests/wpt",
    "description": "Test suites for Web platform specs — including WHATWG, W3C, and others",
    "fork": false,
    "url": "https://api.github.com/repos/web-platform-tests/wpt",
    "forks_url": "https://api.github.com/repos/web-platform-tests/wpt/forks",
    "keys_url": "https://api.github.com/repos/web-platform-tests/wpt/keys{/key_id}",
    "collaborators_url": "https://api.github.com/repos/web-platform-tests/wpt/collaborators{/collaborator}",
    "teams_url": "https://api.github.com/repos/web-platform-tests/wpt/teams",
    "hooks_url": "https://api.github.com/repos/web-platform-tests/wpt/hooks",
    "issue_events_url": "https://api.github.com/repos/web-platform-tests/wpt/issues/events{/number}",
    "events_url": "https://api.github.com/repos/web-platform-tests/wpt/events",
    "assignees_url": "https://api.github.com/repos/web-platform-tests/wpt/assignees{/user}",
    "branches_url": "https://api.github.com/repos/web-platform-tests/wpt/branches{/branch}",
    "tags_url": "https://api.github.com/repos/web-platform-tests/wpt/tags",
    "blobs_url": "https://api.github.com/repos/web-platform-tests/wpt/git/blobs{/sha}",
    "git_tags_url": "https://api.github.com/repos/web-platform-tests/wpt/git/tags{/sha}",
    "git_refs_url": "https://api.github.com/repos/web-platform-tests/wpt/git/refs{/sha}",
    "trees_url": "https://api.github.com/repos/web-platform-tests/wpt/git/trees{/sha}",
    "statuses_url": "https://api.github.com/repos/web-platform-tests/wpt/statuses/{sha}",
    "languages_url": "https://api.github.com/repos/web-platform-tests/wpt/languages",
    "stargazers_url": "https://api.github.com/repos/web-platform-tests/wpt/stargazers",
    "contributors_url": "https://api.github.com/repos/web-platform-tests/wpt/contributors",
    "subscribers_url": "https://api.github.com/repos/web-platform-tests/wpt/subscribers",
    "subscription_url": "https://api.github.com/repos/web-platform-tests/wpt/subscription",
    "commits_url": "https://api.github.com/repos/web-platform-tests/wpt/commits{/sha}",
    "git_commits_url": "https://api.github.com/repos/web-platform-tests/wpt/git/commits{/sha}",
    "comments_url": "https://api.github.com/repos/web-platform-tests/wpt/comments{/number}",
    "issue_comment_url": "https://api.github.com/repos/web-platform-tests/wpt/issues/comments{/number}",
    "contents_url": "https://api.github.com/repos/web-platform-tests/wpt/contents/{+path}",
    "compare_url": "https://api.github.com/repos/web-platform-tests/wpt/compare/{base}...{head}",
    "merges_url": "https://api.github.com/repos/web-platform-tests/wpt/merges",
    "archive_url": "https://api.github.com/repos/web-platform-tests/wpt/{archive_format}{/ref}",
    "downloads_url": "https://api.github.com/repos/web-platform-tests/wpt/downloads",
    "issues_url": "https://api.github.com/repos/web-platform-tests/wpt/issues{/number}",
    "pulls_url": "https://api.github.com/repos/web-platform-tests/wpt/pulls{/number}",
    "milestones_url": "https://api.github.com/repos/web-platform-tests/wpt/milestones{/number}",
    "notifications_url": "https://api.github.com/repos/web-platform-tests/wpt/notifications{?since,all,participating}",
    "labels_url": "https://api.github.com/repos/web-platform-tests/wpt/labels{/name}",
    "releases_url": "https://api.github.com/repos/web-platform-tests/wpt/releases{/id}",
    "deployments_url": "https://api.github.com/repos/web-platform-tests/wpt/deployments",
    "created_at": "2012-03-04T12:58:11Z",
    "updated_at": "2019-10-25T08:36:18Z",
    "pushed_at": "2019-10-25T08:47:19Z",
    "git_url": "git://github.com/web-platform-tests/wpt.git",
    "ssh_url": "[email protected]:web-platform-tests/wpt.git",
    "clone_url": "https://github.com/web-platform-tests/wpt.git",
    "svn_url": "https://github.com/web-platform-tests/wpt",
    "homepage": "https://web-platform-tests.org/",
    "size": 328231,
    "stargazers_count": 2498,
    "watchers_count": 2498,
    "language": "HTML",
    "has_issues": true,
    "has_projects": true,
    "has_downloads": true,
    "has_wiki": true,
    "has_pages": true,
    "forks_count": 1811,
    "mirror_url": null,
    "archived": false,
    "disabled": false,
    "open_issues_count": 1567,
    "license": {
      "key": "other",
      "name": "Other",
      "spdx_id": "NOASSERTION",
      "url": null,
      "node_id": "MDc6TGljZW5zZTA="
    },
    "forks": 1811,
    "open_issues": 1567,
    "watchers": 2498,
    "default_branch": "master"
  },
  "organization": {
    "login": "web-platform-tests",
    "id": 37226233,
    "node_id": "MDEyOk9yZ2FuaXphdGlvbjM3MjI2MjMz",
    "url": "https://api.github.com/orgs/web-platform-tests",
    "repos_url": "https://api.github.com/orgs/web-platform-tests/repos",
    "events_url": "https://api.github.com/orgs/web-platform-tests/events",
    "hooks_url": "https://api.github.com/orgs/web-platform-tests/hooks",
    "issues_url": "https://api.github.com/orgs/web-platform-tests/issues",
    "members_url": "https://api.github.com/orgs/web-platform-tests/members{/member}",
    "public_members_url": "https://api.github.com/orgs/web-platform-tests/public_members{/member}",
    "avatar_url": "https://avatars0.githubusercontent.com/u/37226233?v=4",
    "description": ""
  },
  "sender": {
    "login": "foolip",
    "id": 498917,
    "node_id": "MDQ6VXNlcjQ5ODkxNw==",
    "avatar_url": "https://avatars1.githubusercontent.com/u/498917?v=4",
    "gravatar_id": "",
    "url": "https://api.github.com/users/foolip",
    "html_url": "https://github.com/foolip",
    "followers_url": "https://api.github.com/users/foolip/followers",
    "following_url": "https://api.github.com/users/foolip/following{/other_user}",
    "gists_url": "https://api.github.com/users/foolip/gists{/gist_id}",
    "starred_url": "https://api.github.com/users/foolip/starred{/owner}{/repo}",
    "subscriptions_url": "https://api.github.com/users/foolip/subscriptions",
    "organizations_url": "https://api.github.com/users/foolip/orgs",
    "repos_url": "https://api.github.com/users/foolip/repos",
    "events_url": "https://api.github.com/users/foolip/events{/privacy}",
    "received_events_url": "https://api.github.com/users/foolip/received_events",
    "type": "User",
    "site_admin": false
  }
}

@foolip
Copy link
Member Author

foolip commented Oct 25, 2019

The other input to the code would be https://api.github.com/repos/web-platform-tests/wpt/pulls/19879, which has changed by now but the relevant bits are probably still the same:

{
  "url": "https://api.github.com/repos/web-platform-tests/wpt/pulls/19879",
  "id": 332398365,
  "node_id": "MDExOlB1bGxSZXF1ZXN0MzMyMzk4MzY1",
  "html_url": "https://github.com/web-platform-tests/wpt/pull/19879",
  "diff_url": "https://github.com/web-platform-tests/wpt/pull/19879.diff",
  "patch_url": "https://github.com/web-platform-tests/wpt/pull/19879.patch",
  "issue_url": "https://api.github.com/repos/web-platform-tests/wpt/issues/19879",
  "number": 19879,
  "state": "open",
  "locked": false,
  "title": "[infra] remove the top-level wpt.py",
  "user": {
    "login": "foolip",
    "id": 498917,
    "node_id": "MDQ6VXNlcjQ5ODkxNw==",
    "avatar_url": "https://avatars1.githubusercontent.com/u/498917?v=4",
    "gravatar_id": "",
    "url": "https://api.github.com/users/foolip",
    "html_url": "https://github.com/foolip",
    "followers_url": "https://api.github.com/users/foolip/followers",
    "following_url": "https://api.github.com/users/foolip/following{/other_user}",
    "gists_url": "https://api.github.com/users/foolip/gists{/gist_id}",
    "starred_url": "https://api.github.com/users/foolip/starred{/owner}{/repo}",
    "subscriptions_url": "https://api.github.com/users/foolip/subscriptions",
    "organizations_url": "https://api.github.com/users/foolip/orgs",
    "repos_url": "https://api.github.com/users/foolip/repos",
    "events_url": "https://api.github.com/users/foolip/events{/privacy}",
    "received_events_url": "https://api.github.com/users/foolip/received_events",
    "type": "User",
    "site_admin": false
  },
  "body": "",
  "created_at": "2019-10-25T08:28:32Z",
  "updated_at": "2019-10-25T08:49:13Z",
  "closed_at": null,
  "merged_at": null,
  "merge_commit_sha": "ab65bb2815db40f7af5f72f7d6d3f578ecee6bd2",
  "assignee": {
    "login": "jugglinmike",
    "id": 677252,
    "node_id": "MDQ6VXNlcjY3NzI1Mg==",
    "avatar_url": "https://avatars2.githubusercontent.com/u/677252?v=4",
    "gravatar_id": "",
    "url": "https://api.github.com/users/jugglinmike",
    "html_url": "https://github.com/jugglinmike",
    "followers_url": "https://api.github.com/users/jugglinmike/followers",
    "following_url": "https://api.github.com/users/jugglinmike/following{/other_user}",
    "gists_url": "https://api.github.com/users/jugglinmike/gists{/gist_id}",
    "starred_url": "https://api.github.com/users/jugglinmike/starred{/owner}{/repo}",
    "subscriptions_url": "https://api.github.com/users/jugglinmike/subscriptions",
    "organizations_url": "https://api.github.com/users/jugglinmike/orgs",
    "repos_url": "https://api.github.com/users/jugglinmike/repos",
    "events_url": "https://api.github.com/users/jugglinmike/events{/privacy}",
    "received_events_url": "https://api.github.com/users/jugglinmike/received_events",
    "type": "User",
    "site_admin": false
  },
  "assignees": [
    {
      "login": "jugglinmike",
      "id": 677252,
      "node_id": "MDQ6VXNlcjY3NzI1Mg==",
      "avatar_url": "https://avatars2.githubusercontent.com/u/677252?v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/jugglinmike",
      "html_url": "https://github.com/jugglinmike",
      "followers_url": "https://api.github.com/users/jugglinmike/followers",
      "following_url": "https://api.github.com/users/jugglinmike/following{/other_user}",
      "gists_url": "https://api.github.com/users/jugglinmike/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/jugglinmike/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/jugglinmike/subscriptions",
      "organizations_url": "https://api.github.com/users/jugglinmike/orgs",
      "repos_url": "https://api.github.com/users/jugglinmike/repos",
      "events_url": "https://api.github.com/users/jugglinmike/events{/privacy}",
      "received_events_url": "https://api.github.com/users/jugglinmike/received_events",
      "type": "User",
      "site_admin": false
    }
  ],
  "requested_reviewers": [
    {
      "login": "gsnedders",
      "id": 176218,
      "node_id": "MDQ6VXNlcjE3NjIxOA==",
      "avatar_url": "https://avatars2.githubusercontent.com/u/176218?v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/gsnedders",
      "html_url": "https://github.com/gsnedders",
      "followers_url": "https://api.github.com/users/gsnedders/followers",
      "following_url": "https://api.github.com/users/gsnedders/following{/other_user}",
      "gists_url": "https://api.github.com/users/gsnedders/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/gsnedders/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/gsnedders/subscriptions",
      "organizations_url": "https://api.github.com/users/gsnedders/orgs",
      "repos_url": "https://api.github.com/users/gsnedders/repos",
      "events_url": "https://api.github.com/users/gsnedders/events{/privacy}",
      "received_events_url": "https://api.github.com/users/gsnedders/received_events",
      "type": "User",
      "site_admin": false
    },
    {
      "login": "sideshowbarker",
      "id": 194984,
      "node_id": "MDQ6VXNlcjE5NDk4NA==",
      "avatar_url": "https://avatars2.githubusercontent.com/u/194984?v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/sideshowbarker",
      "html_url": "https://github.com/sideshowbarker",
      "followers_url": "https://api.github.com/users/sideshowbarker/followers",
      "following_url": "https://api.github.com/users/sideshowbarker/following{/other_user}",
      "gists_url": "https://api.github.com/users/sideshowbarker/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/sideshowbarker/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/sideshowbarker/subscriptions",
      "organizations_url": "https://api.github.com/users/sideshowbarker/orgs",
      "repos_url": "https://api.github.com/users/sideshowbarker/repos",
      "events_url": "https://api.github.com/users/sideshowbarker/events{/privacy}",
      "received_events_url": "https://api.github.com/users/sideshowbarker/received_events",
      "type": "User",
      "site_admin": false
    },
    {
      "login": "jgraham",
      "id": 294864,
      "node_id": "MDQ6VXNlcjI5NDg2NA==",
      "avatar_url": "https://avatars1.githubusercontent.com/u/294864?v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/jgraham",
      "html_url": "https://github.com/jgraham",
      "followers_url": "https://api.github.com/users/jgraham/followers",
      "following_url": "https://api.github.com/users/jgraham/following{/other_user}",
      "gists_url": "https://api.github.com/users/jgraham/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/jgraham/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/jgraham/subscriptions",
      "organizations_url": "https://api.github.com/users/jgraham/orgs",
      "repos_url": "https://api.github.com/users/jgraham/repos",
      "events_url": "https://api.github.com/users/jgraham/events{/privacy}",
      "received_events_url": "https://api.github.com/users/jgraham/received_events",
      "type": "User",
      "site_admin": false
    },
    {
      "login": "jugglinmike",
      "id": 677252,
      "node_id": "MDQ6VXNlcjY3NzI1Mg==",
      "avatar_url": "https://avatars2.githubusercontent.com/u/677252?v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/jugglinmike",
      "html_url": "https://github.com/jugglinmike",
      "followers_url": "https://api.github.com/users/jugglinmike/followers",
      "following_url": "https://api.github.com/users/jugglinmike/following{/other_user}",
      "gists_url": "https://api.github.com/users/jugglinmike/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/jugglinmike/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/jugglinmike/subscriptions",
      "organizations_url": "https://api.github.com/users/jugglinmike/orgs",
      "repos_url": "https://api.github.com/users/jugglinmike/repos",
      "events_url": "https://api.github.com/users/jugglinmike/events{/privacy}",
      "received_events_url": "https://api.github.com/users/jugglinmike/received_events",
      "type": "User",
      "site_admin": false
    }
  ],
  "requested_teams": [

  ],
  "labels": [
    {
      "id": 1239627882,
      "node_id": "MDU6TGFiZWwxMjM5NjI3ODgy",
      "url": "https://api.github.com/repos/web-platform-tests/wpt/labels/Azure%20Pipelines",
      "name": "Azure Pipelines",
      "color": "fef2c0",
      "default": false
    },
    {
      "id": 1012999603,
      "node_id": "MDU6TGFiZWwxMDEyOTk5NjAz",
      "url": "https://api.github.com/repos/web-platform-tests/wpt/labels/ci",
      "name": "ci",
      "color": "fef2c0",
      "default": false
    },
    {
      "id": 125445429,
      "node_id": "MDU6TGFiZWwxMjU0NDU0Mjk=",
      "url": "https://api.github.com/repos/web-platform-tests/wpt/labels/docs",
      "name": "docs",
      "color": "fbca04",
      "default": false
    },
    {
      "id": 45230790,
      "node_id": "MDU6TGFiZWw0NTIzMDc5MA==",
      "url": "https://api.github.com/repos/web-platform-tests/wpt/labels/infra",
      "name": "infra",
      "color": "fbca04",
      "default": false
    }
  ],
  "milestone": null,
  "commits_url": "https://api.github.com/repos/web-platform-tests/wpt/pulls/19879/commits",
  "review_comments_url": "https://api.github.com/repos/web-platform-tests/wpt/pulls/19879/comments",
  "review_comment_url": "https://api.github.com/repos/web-platform-tests/wpt/pulls/comments{/number}",
  "comments_url": "https://api.github.com/repos/web-platform-tests/wpt/issues/19879/comments",
  "statuses_url": "https://api.github.com/repos/web-platform-tests/wpt/statuses/87cee9cc56d9820035a6ac83dafa52c8a55a38d5",
  "head": {
    "label": "web-platform-tests:foolip/rm-wpt.py",
    "ref": "foolip/rm-wpt.py",
    "sha": "87cee9cc56d9820035a6ac83dafa52c8a55a38d5",
    "user": {
      "login": "web-platform-tests",
      "id": 37226233,
      "node_id": "MDEyOk9yZ2FuaXphdGlvbjM3MjI2MjMz",
      "avatar_url": "https://avatars0.githubusercontent.com/u/37226233?v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/web-platform-tests",
      "html_url": "https://github.com/web-platform-tests",
      "followers_url": "https://api.github.com/users/web-platform-tests/followers",
      "following_url": "https://api.github.com/users/web-platform-tests/following{/other_user}",
      "gists_url": "https://api.github.com/users/web-platform-tests/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/web-platform-tests/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/web-platform-tests/subscriptions",
      "organizations_url": "https://api.github.com/users/web-platform-tests/orgs",
      "repos_url": "https://api.github.com/users/web-platform-tests/repos",
      "events_url": "https://api.github.com/users/web-platform-tests/events{/privacy}",
      "received_events_url": "https://api.github.com/users/web-platform-tests/received_events",
      "type": "Organization",
      "site_admin": false
    },
    "repo": {
      "id": 3618133,
      "node_id": "MDEwOlJlcG9zaXRvcnkzNjE4MTMz",
      "name": "wpt",
      "full_name": "web-platform-tests/wpt",
      "private": false,
      "owner": {
        "login": "web-platform-tests",
        "id": 37226233,
        "node_id": "MDEyOk9yZ2FuaXphdGlvbjM3MjI2MjMz",
        "avatar_url": "https://avatars0.githubusercontent.com/u/37226233?v=4",
        "gravatar_id": "",
        "url": "https://api.github.com/users/web-platform-tests",
        "html_url": "https://github.com/web-platform-tests",
        "followers_url": "https://api.github.com/users/web-platform-tests/followers",
        "following_url": "https://api.github.com/users/web-platform-tests/following{/other_user}",
        "gists_url": "https://api.github.com/users/web-platform-tests/gists{/gist_id}",
        "starred_url": "https://api.github.com/users/web-platform-tests/starred{/owner}{/repo}",
        "subscriptions_url": "https://api.github.com/users/web-platform-tests/subscriptions",
        "organizations_url": "https://api.github.com/users/web-platform-tests/orgs",
        "repos_url": "https://api.github.com/users/web-platform-tests/repos",
        "events_url": "https://api.github.com/users/web-platform-tests/events{/privacy}",
        "received_events_url": "https://api.github.com/users/web-platform-tests/received_events",
        "type": "Organization",
        "site_admin": false
      },
      "html_url": "https://github.com/web-platform-tests/wpt",
      "description": "Test suites for Web platform specs — including WHATWG, W3C, and others",
      "fork": false,
      "url": "https://api.github.com/repos/web-platform-tests/wpt",
      "forks_url": "https://api.github.com/repos/web-platform-tests/wpt/forks",
      "keys_url": "https://api.github.com/repos/web-platform-tests/wpt/keys{/key_id}",
      "collaborators_url": "https://api.github.com/repos/web-platform-tests/wpt/collaborators{/collaborator}",
      "teams_url": "https://api.github.com/repos/web-platform-tests/wpt/teams",
      "hooks_url": "https://api.github.com/repos/web-platform-tests/wpt/hooks",
      "issue_events_url": "https://api.github.com/repos/web-platform-tests/wpt/issues/events{/number}",
      "events_url": "https://api.github.com/repos/web-platform-tests/wpt/events",
      "assignees_url": "https://api.github.com/repos/web-platform-tests/wpt/assignees{/user}",
      "branches_url": "https://api.github.com/repos/web-platform-tests/wpt/branches{/branch}",
      "tags_url": "https://api.github.com/repos/web-platform-tests/wpt/tags",
      "blobs_url": "https://api.github.com/repos/web-platform-tests/wpt/git/blobs{/sha}",
      "git_tags_url": "https://api.github.com/repos/web-platform-tests/wpt/git/tags{/sha}",
      "git_refs_url": "https://api.github.com/repos/web-platform-tests/wpt/git/refs{/sha}",
      "trees_url": "https://api.github.com/repos/web-platform-tests/wpt/git/trees{/sha}",
      "statuses_url": "https://api.github.com/repos/web-platform-tests/wpt/statuses/{sha}",
      "languages_url": "https://api.github.com/repos/web-platform-tests/wpt/languages",
      "stargazers_url": "https://api.github.com/repos/web-platform-tests/wpt/stargazers",
      "contributors_url": "https://api.github.com/repos/web-platform-tests/wpt/contributors",
      "subscribers_url": "https://api.github.com/repos/web-platform-tests/wpt/subscribers",
      "subscription_url": "https://api.github.com/repos/web-platform-tests/wpt/subscription",
      "commits_url": "https://api.github.com/repos/web-platform-tests/wpt/commits{/sha}",
      "git_commits_url": "https://api.github.com/repos/web-platform-tests/wpt/git/commits{/sha}",
      "comments_url": "https://api.github.com/repos/web-platform-tests/wpt/comments{/number}",
      "issue_comment_url": "https://api.github.com/repos/web-platform-tests/wpt/issues/comments{/number}",
      "contents_url": "https://api.github.com/repos/web-platform-tests/wpt/contents/{+path}",
      "compare_url": "https://api.github.com/repos/web-platform-tests/wpt/compare/{base}...{head}",
      "merges_url": "https://api.github.com/repos/web-platform-tests/wpt/merges",
      "archive_url": "https://api.github.com/repos/web-platform-tests/wpt/{archive_format}{/ref}",
      "downloads_url": "https://api.github.com/repos/web-platform-tests/wpt/downloads",
      "issues_url": "https://api.github.com/repos/web-platform-tests/wpt/issues{/number}",
      "pulls_url": "https://api.github.com/repos/web-platform-tests/wpt/pulls{/number}",
      "milestones_url": "https://api.github.com/repos/web-platform-tests/wpt/milestones{/number}",
      "notifications_url": "https://api.github.com/repos/web-platform-tests/wpt/notifications{?since,all,participating}",
      "labels_url": "https://api.github.com/repos/web-platform-tests/wpt/labels{/name}",
      "releases_url": "https://api.github.com/repos/web-platform-tests/wpt/releases{/id}",
      "deployments_url": "https://api.github.com/repos/web-platform-tests/wpt/deployments",
      "created_at": "2012-03-04T12:58:11Z",
      "updated_at": "2019-10-25T08:36:18Z",
      "pushed_at": "2019-10-25T08:47:19Z",
      "git_url": "git://github.com/web-platform-tests/wpt.git",
      "ssh_url": "[email protected]:web-platform-tests/wpt.git",
      "clone_url": "https://github.com/web-platform-tests/wpt.git",
      "svn_url": "https://github.com/web-platform-tests/wpt",
      "homepage": "https://web-platform-tests.org/",
      "size": 328231,
      "stargazers_count": 2498,
      "watchers_count": 2498,
      "language": "HTML",
      "has_issues": true,
      "has_projects": true,
      "has_downloads": true,
      "has_wiki": true,
      "has_pages": true,
      "forks_count": 1811,
      "mirror_url": null,
      "archived": false,
      "disabled": false,
      "open_issues_count": 1567,
      "license": {
        "key": "other",
        "name": "Other",
        "spdx_id": "NOASSERTION",
        "url": null,
        "node_id": "MDc6TGljZW5zZTA="
      },
      "forks": 1811,
      "open_issues": 1567,
      "watchers": 2498,
      "default_branch": "master"
    }
  },
  "base": {
    "label": "web-platform-tests:master",
    "ref": "master",
    "sha": "4efaeb295baf76c416c3c32ecf8d81d6c602ad11",
    "user": {
      "login": "web-platform-tests",
      "id": 37226233,
      "node_id": "MDEyOk9yZ2FuaXphdGlvbjM3MjI2MjMz",
      "avatar_url": "https://avatars0.githubusercontent.com/u/37226233?v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/web-platform-tests",
      "html_url": "https://github.com/web-platform-tests",
      "followers_url": "https://api.github.com/users/web-platform-tests/followers",
      "following_url": "https://api.github.com/users/web-platform-tests/following{/other_user}",
      "gists_url": "https://api.github.com/users/web-platform-tests/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/web-platform-tests/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/web-platform-tests/subscriptions",
      "organizations_url": "https://api.github.com/users/web-platform-tests/orgs",
      "repos_url": "https://api.github.com/users/web-platform-tests/repos",
      "events_url": "https://api.github.com/users/web-platform-tests/events{/privacy}",
      "received_events_url": "https://api.github.com/users/web-platform-tests/received_events",
      "type": "Organization",
      "site_admin": false
    },
    "repo": {
      "id": 3618133,
      "node_id": "MDEwOlJlcG9zaXRvcnkzNjE4MTMz",
      "name": "wpt",
      "full_name": "web-platform-tests/wpt",
      "private": false,
      "owner": {
        "login": "web-platform-tests",
        "id": 37226233,
        "node_id": "MDEyOk9yZ2FuaXphdGlvbjM3MjI2MjMz",
        "avatar_url": "https://avatars0.githubusercontent.com/u/37226233?v=4",
        "gravatar_id": "",
        "url": "https://api.github.com/users/web-platform-tests",
        "html_url": "https://github.com/web-platform-tests",
        "followers_url": "https://api.github.com/users/web-platform-tests/followers",
        "following_url": "https://api.github.com/users/web-platform-tests/following{/other_user}",
        "gists_url": "https://api.github.com/users/web-platform-tests/gists{/gist_id}",
        "starred_url": "https://api.github.com/users/web-platform-tests/starred{/owner}{/repo}",
        "subscriptions_url": "https://api.github.com/users/web-platform-tests/subscriptions",
        "organizations_url": "https://api.github.com/users/web-platform-tests/orgs",
        "repos_url": "https://api.github.com/users/web-platform-tests/repos",
        "events_url": "https://api.github.com/users/web-platform-tests/events{/privacy}",
        "received_events_url": "https://api.github.com/users/web-platform-tests/received_events",
        "type": "Organization",
        "site_admin": false
      },
      "html_url": "https://github.com/web-platform-tests/wpt",
      "description": "Test suites for Web platform specs — including WHATWG, W3C, and others",
      "fork": false,
      "url": "https://api.github.com/repos/web-platform-tests/wpt",
      "forks_url": "https://api.github.com/repos/web-platform-tests/wpt/forks",
      "keys_url": "https://api.github.com/repos/web-platform-tests/wpt/keys{/key_id}",
      "collaborators_url": "https://api.github.com/repos/web-platform-tests/wpt/collaborators{/collaborator}",
      "teams_url": "https://api.github.com/repos/web-platform-tests/wpt/teams",
      "hooks_url": "https://api.github.com/repos/web-platform-tests/wpt/hooks",
      "issue_events_url": "https://api.github.com/repos/web-platform-tests/wpt/issues/events{/number}",
      "events_url": "https://api.github.com/repos/web-platform-tests/wpt/events",
      "assignees_url": "https://api.github.com/repos/web-platform-tests/wpt/assignees{/user}",
      "branches_url": "https://api.github.com/repos/web-platform-tests/wpt/branches{/branch}",
      "tags_url": "https://api.github.com/repos/web-platform-tests/wpt/tags",
      "blobs_url": "https://api.github.com/repos/web-platform-tests/wpt/git/blobs{/sha}",
      "git_tags_url": "https://api.github.com/repos/web-platform-tests/wpt/git/tags{/sha}",
      "git_refs_url": "https://api.github.com/repos/web-platform-tests/wpt/git/refs{/sha}",
      "trees_url": "https://api.github.com/repos/web-platform-tests/wpt/git/trees{/sha}",
      "statuses_url": "https://api.github.com/repos/web-platform-tests/wpt/statuses/{sha}",
      "languages_url": "https://api.github.com/repos/web-platform-tests/wpt/languages",
      "stargazers_url": "https://api.github.com/repos/web-platform-tests/wpt/stargazers",
      "contributors_url": "https://api.github.com/repos/web-platform-tests/wpt/contributors",
      "subscribers_url": "https://api.github.com/repos/web-platform-tests/wpt/subscribers",
      "subscription_url": "https://api.github.com/repos/web-platform-tests/wpt/subscription",
      "commits_url": "https://api.github.com/repos/web-platform-tests/wpt/commits{/sha}",
      "git_commits_url": "https://api.github.com/repos/web-platform-tests/wpt/git/commits{/sha}",
      "comments_url": "https://api.github.com/repos/web-platform-tests/wpt/comments{/number}",
      "issue_comment_url": "https://api.github.com/repos/web-platform-tests/wpt/issues/comments{/number}",
      "contents_url": "https://api.github.com/repos/web-platform-tests/wpt/contents/{+path}",
      "compare_url": "https://api.github.com/repos/web-platform-tests/wpt/compare/{base}...{head}",
      "merges_url": "https://api.github.com/repos/web-platform-tests/wpt/merges",
      "archive_url": "https://api.github.com/repos/web-platform-tests/wpt/{archive_format}{/ref}",
      "downloads_url": "https://api.github.com/repos/web-platform-tests/wpt/downloads",
      "issues_url": "https://api.github.com/repos/web-platform-tests/wpt/issues{/number}",
      "pulls_url": "https://api.github.com/repos/web-platform-tests/wpt/pulls{/number}",
      "milestones_url": "https://api.github.com/repos/web-platform-tests/wpt/milestones{/number}",
      "notifications_url": "https://api.github.com/repos/web-platform-tests/wpt/notifications{?since,all,participating}",
      "labels_url": "https://api.github.com/repos/web-platform-tests/wpt/labels{/name}",
      "releases_url": "https://api.github.com/repos/web-platform-tests/wpt/releases{/id}",
      "deployments_url": "https://api.github.com/repos/web-platform-tests/wpt/deployments",
      "created_at": "2012-03-04T12:58:11Z",
      "updated_at": "2019-10-25T08:36:18Z",
      "pushed_at": "2019-10-25T08:47:19Z",
      "git_url": "git://github.com/web-platform-tests/wpt.git",
      "ssh_url": "[email protected]:web-platform-tests/wpt.git",
      "clone_url": "https://github.com/web-platform-tests/wpt.git",
      "svn_url": "https://github.com/web-platform-tests/wpt",
      "homepage": "https://web-platform-tests.org/",
      "size": 328231,
      "stargazers_count": 2498,
      "watchers_count": 2498,
      "language": "HTML",
      "has_issues": true,
      "has_projects": true,
      "has_downloads": true,
      "has_wiki": true,
      "has_pages": true,
      "forks_count": 1811,
      "mirror_url": null,
      "archived": false,
      "disabled": false,
      "open_issues_count": 1567,
      "license": {
        "key": "other",
        "name": "Other",
        "spdx_id": "NOASSERTION",
        "url": null,
        "node_id": "MDc6TGljZW5zZTA="
      },
      "forks": 1811,
      "open_issues": 1567,
      "watchers": 2498,
      "default_branch": "master"
    }
  },
  "_links": {
    "self": {
      "href": "https://api.github.com/repos/web-platform-tests/wpt/pulls/19879"
    },
    "html": {
      "href": "https://github.com/web-platform-tests/wpt/pull/19879"
    },
    "issue": {
      "href": "https://api.github.com/repos/web-platform-tests/wpt/issues/19879"
    },
    "comments": {
      "href": "https://api.github.com/repos/web-platform-tests/wpt/issues/19879/comments"
    },
    "review_comments": {
      "href": "https://api.github.com/repos/web-platform-tests/wpt/pulls/19879/comments"
    },
    "review_comment": {
      "href": "https://api.github.com/repos/web-platform-tests/wpt/pulls/comments{/number}"
    },
    "commits": {
      "href": "https://api.github.com/repos/web-platform-tests/wpt/pulls/19879/commits"
    },
    "statuses": {
      "href": "https://api.github.com/repos/web-platform-tests/wpt/statuses/87cee9cc56d9820035a6ac83dafa52c8a55a38d5"
    }
  },
  "author_association": "CONTRIBUTOR",
  "merged": false,
  "mergeable": true,
  "rebaseable": true,
  "mergeable_state": "draft",
  "merged_by": null,
  "comments": 2,
  "review_comments": 0,
  "maintainer_can_modify": false,
  "commits": 3,
  "additions": 14,
  "deletions": 15,
  "changed_files": 7
}

@foolip
Copy link
Member Author

foolip commented Oct 25, 2019

Huh, #69 (comment) doesn't include draft.

From https://developer.github.com/v3/pulls/#get-a-single-pull-request it looks like you need Accept: application/vnd.github.shadow-cat-preview+json for this to work.

Funny enough, "mergeable_state": "draft" still reveals that it's a draft :)

@foolip
Copy link
Member Author

foolip commented Oct 25, 2019

Using https://octokit.github.io/rest.js/ would mean we don't have to care about this sort of thing...

foolip added a commit that referenced this issue Oct 25, 2019
@foolip
Also check mergeable_state to identify draft pull requests
f23636d 
This field can currently be observed here:
https://api.github.com/repos/web-platform-tests/wpt/pulls/19806

There's no stability guarantee here, it's a quickfix.

Fixes #69.
@foolip foolip mentioned this issue Oct 25, 2019
Merged
zcorpan pushed a commit that referenced this issue Oct 28, 2019
@foolip @zcorpan
Also check mergeable_state to identify draft pull requests
12e6b9b 
This field can currently be observed here:
https://api.github.com/repos/web-platform-tests/wpt/pulls/19806

There's no stability guarantee here, it's a quickfix.

Fixes #69.
@foolip foolip mentioned this issue Nov 7, 2019
Closed
@foolip
Copy link
Member Author

foolip commented Nov 8, 2019

Oh no... it's still not fixed. Commenting on a PR brings the unwanted attention of wpt-pr-bot:
web-platform-tests/wpt#20176

:'(

@foolip foolip reopened this Nov 8, 2019
@foolip foolip mentioned this issue Nov 8, 2019
Closed
@foolip
Copy link
Member Author

foolip commented Nov 8, 2019

I think this is the webhook delivery that must have done it this time:

Headers

Request URL: https://wpt-pr-bot.herokuapp.com/github-hook
Request method: POST
content-type: application/json
Expect: 
User-Agent: GitHub-Hookshot/f1003bc
X-GitHub-Delivery: 73ac7300-0242-11ea-9862-9228e08f7fd6
X-GitHub-Event: pull_request_review_comment
X-Hub-Signature: [redacted]

Payload

{
  "action": "created",
  "comment": {
    "url": "https://api.github.com/repos/web-platform-tests/wpt/pulls/comments/344250099",
    "pull_request_review_id": 314303020,
    "id": 344250099,
    "node_id": "MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0NDI1MDA5OQ==",
    "diff_hunk": "@@ -65,6 +65,8 @@ function run_test(algorithmNames, slowTest) {\n                     assert_goodCryptoKey(result, algorithm, extractable, usages, \"secret\");\n                 }\n             }, function(err) {\n+                var supported = !err.toString().includes('not supported');",
    "path": "WebCryptoAPI/generateKey/successes.js",
    "position": 4,
    "original_position": 4,
    "commit_id": "911c33927a1c01ee0ecf50efd60e0e238e6e2f95",
    "original_commit_id": "911c33927a1c01ee0ecf50efd60e0e238e6e2f95",
    "user": {
      "login": "foolip",
      "id": 498917,
      "node_id": "MDQ6VXNlcjQ5ODkxNw==",
      "avatar_url": "https://avatars1.githubusercontent.com/u/498917?v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/foolip",
      "html_url": "https://github.com/foolip",
      "followers_url": "https://api.github.com/users/foolip/followers",
      "following_url": "https://api.github.com/users/foolip/following{/other_user}",
      "gists_url": "https://api.github.com/users/foolip/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/foolip/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/foolip/subscriptions",
      "organizations_url": "https://api.github.com/users/foolip/orgs",
      "repos_url": "https://api.github.com/users/foolip/repos",
      "events_url": "https://api.github.com/users/foolip/events{/privacy}",
      "received_events_url": "https://api.github.com/users/foolip/received_events",
      "type": "User",
      "site_admin": false
    },
    "body": "This is testing the error message which isn't defined by the spec. Unfortunately per https://w3c.github.io/webcrypto/#SubtleCrypto-Exceptions (and algorithms) it looks like the DOMException type to check for would be \"NotSupportedError\" but Chromium actually uses \"OperationError\", so I think Chromium would need to change...",
    "created_at": "2019-11-08T16:11:41Z",
    "updated_at": "2019-11-08T16:11:42Z",
    "html_url": "https://github.com/web-platform-tests/wpt/pull/20176#discussion_r344250099",
    "pull_request_url": "https://api.github.com/repos/web-platform-tests/wpt/pulls/20176",
    "author_association": "CONTRIBUTOR",
    "_links": {
      "self": {
        "href": "https://api.github.com/repos/web-platform-tests/wpt/pulls/comments/344250099"
      },
      "html": {
        "href": "https://github.com/web-platform-tests/wpt/pull/20176#discussion_r344250099"
      },
      "pull_request": {
        "href": "https://api.github.com/repos/web-platform-tests/wpt/pulls/20176"
      }
    }
  },
  "pull_request": {
    "url": "https://api.github.com/repos/web-platform-tests/wpt/pulls/20176",
    "id": 338677770,
    "node_id": "MDExOlB1bGxSZXF1ZXN0MzM4Njc3Nzcw",
    "html_url": "https://github.com/web-platform-tests/wpt/pull/20176",
    "diff_url": "https://github.com/web-platform-tests/wpt/pull/20176.diff",
    "patch_url": "https://github.com/web-platform-tests/wpt/pull/20176.patch",
    "issue_url": "https://api.github.com/repos/web-platform-tests/wpt/issues/20176",
    "number": 20176,
    "state": "open",
    "locked": false,
    "title": "[WebCryptoAPI] use `assert_precondition` to avoid spurious failures",
    "user": {
      "login": "foolip",
      "id": 498917,
      "node_id": "MDQ6VXNlcjQ5ODkxNw==",
      "avatar_url": "https://avatars1.githubusercontent.com/u/498917?v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/foolip",
      "html_url": "https://github.com/foolip",
      "followers_url": "https://api.github.com/users/foolip/followers",
      "following_url": "https://api.github.com/users/foolip/following{/other_user}",
      "gists_url": "https://api.github.com/users/foolip/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/foolip/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/foolip/subscriptions",
      "organizations_url": "https://api.github.com/users/foolip/orgs",
      "repos_url": "https://api.github.com/users/foolip/repos",
      "events_url": "https://api.github.com/users/foolip/events{/privacy}",
      "received_events_url": "https://api.github.com/users/foolip/received_events",
      "type": "User",
      "site_admin": false
    },
    "body": "",
    "created_at": "2019-11-08T13:31:01Z",
    "updated_at": "2019-11-08T16:11:42Z",
    "closed_at": null,
    "merged_at": null,
    "merge_commit_sha": "e9b37fd0614fac9958e0adff59891b6c346c9978",
    "assignee": null,
    "assignees": [

    ],
    "requested_reviewers": [

    ],
    "requested_teams": [

    ],
    "labels": [

    ],
    "milestone": null,
    "commits_url": "https://api.github.com/repos/web-platform-tests/wpt/pulls/20176/commits",
    "review_comments_url": "https://api.github.com/repos/web-platform-tests/wpt/pulls/20176/comments",
    "review_comment_url": "https://api.github.com/repos/web-platform-tests/wpt/pulls/comments{/number}",
    "comments_url": "https://api.github.com/repos/web-platform-tests/wpt/issues/20176/comments",
    "statuses_url": "https://api.github.com/repos/web-platform-tests/wpt/statuses/911c33927a1c01ee0ecf50efd60e0e238e6e2f95",
    "head": {
      "label": "web-platform-tests:foolip/assert_unreached-WebCryptoAPI",
      "ref": "foolip/assert_unreached-WebCryptoAPI",
      "sha": "911c33927a1c01ee0ecf50efd60e0e238e6e2f95",
      "user": {
        "login": "web-platform-tests",
        "id": 37226233,
        "node_id": "MDEyOk9yZ2FuaXphdGlvbjM3MjI2MjMz",
        "avatar_url": "https://avatars0.githubusercontent.com/u/37226233?v=4",
        "gravatar_id": "",
        "url": "https://api.github.com/users/web-platform-tests",
        "html_url": "https://github.com/web-platform-tests",
        "followers_url": "https://api.github.com/users/web-platform-tests/followers",
        "following_url": "https://api.github.com/users/web-platform-tests/following{/other_user}",
        "gists_url": "https://api.github.com/users/web-platform-tests/gists{/gist_id}",
        "starred_url": "https://api.github.com/users/web-platform-tests/starred{/owner}{/repo}",
        "subscriptions_url": "https://api.github.com/users/web-platform-tests/subscriptions",
        "organizations_url": "https://api.github.com/users/web-platform-tests/orgs",
        "repos_url": "https://api.github.com/users/web-platform-tests/repos",
        "events_url": "https://api.github.com/users/web-platform-tests/events{/privacy}",
        "received_events_url": "https://api.github.com/users/web-platform-tests/received_events",
        "type": "Organization",
        "site_admin": false
      },
      "repo": {
        "id": 3618133,
        "node_id": "MDEwOlJlcG9zaXRvcnkzNjE4MTMz",
        "name": "wpt",
        "full_name": "web-platform-tests/wpt",
        "private": false,
        "owner": {
          "login": "web-platform-tests",
          "id": 37226233,
          "node_id": "MDEyOk9yZ2FuaXphdGlvbjM3MjI2MjMz",
          "avatar_url": "https://avatars0.githubusercontent.com/u/37226233?v=4",
          "gravatar_id": "",
          "url": "https://api.github.com/users/web-platform-tests",
          "html_url": "https://github.com/web-platform-tests",
          "followers_url": "https://api.github.com/users/web-platform-tests/followers",
          "following_url": "https://api.github.com/users/web-platform-tests/following{/other_user}",
          "gists_url": "https://api.github.com/users/web-platform-tests/gists{/gist_id}",
          "starred_url": "https://api.github.com/users/web-platform-tests/starred{/owner}{/repo}",
          "subscriptions_url": "https://api.github.com/users/web-platform-tests/subscriptions",
          "organizations_url": "https://api.github.com/users/web-platform-tests/orgs",
          "repos_url": "https://api.github.com/users/web-platform-tests/repos",
          "events_url": "https://api.github.com/users/web-platform-tests/events{/privacy}",
          "received_events_url": "https://api.github.com/users/web-platform-tests/received_events",
          "type": "Organization",
          "site_admin": false
        },
        "html_url": "https://github.com/web-platform-tests/wpt",
        "description": "Test suites for Web platform specs — including WHATWG, W3C, and others",
        "fork": false,
        "url": "https://api.github.com/repos/web-platform-tests/wpt",
        "forks_url": "https://api.github.com/repos/web-platform-tests/wpt/forks",
        "keys_url": "https://api.github.com/repos/web-platform-tests/wpt/keys{/key_id}",
        "collaborators_url": "https://api.github.com/repos/web-platform-tests/wpt/collaborators{/collaborator}",
        "teams_url": "https://api.github.com/repos/web-platform-tests/wpt/teams",
        "hooks_url": "https://api.github.com/repos/web-platform-tests/wpt/hooks",
        "issue_events_url": "https://api.github.com/repos/web-platform-tests/wpt/issues/events{/number}",
        "events_url": "https://api.github.com/repos/web-platform-tests/wpt/events",
        "assignees_url": "https://api.github.com/repos/web-platform-tests/wpt/assignees{/user}",
        "branches_url": "https://api.github.com/repos/web-platform-tests/wpt/branches{/branch}",
        "tags_url": "https://api.github.com/repos/web-platform-tests/wpt/tags",
        "blobs_url": "https://api.github.com/repos/web-platform-tests/wpt/git/blobs{/sha}",
        "git_tags_url": "https://api.github.com/repos/web-platform-tests/wpt/git/tags{/sha}",
        "git_refs_url": "https://api.github.com/repos/web-platform-tests/wpt/git/refs{/sha}",
        "trees_url": "https://api.github.com/repos/web-platform-tests/wpt/git/trees{/sha}",
        "statuses_url": "https://api.github.com/repos/web-platform-tests/wpt/statuses/{sha}",
        "languages_url": "https://api.github.com/repos/web-platform-tests/wpt/languages",
        "stargazers_url": "https://api.github.com/repos/web-platform-tests/wpt/stargazers",
        "contributors_url": "https://api.github.com/repos/web-platform-tests/wpt/contributors",
        "subscribers_url": "https://api.github.com/repos/web-platform-tests/wpt/subscribers",
        "subscription_url": "https://api.github.com/repos/web-platform-tests/wpt/subscription",
        "commits_url": "https://api.github.com/repos/web-platform-tests/wpt/commits{/sha}",
        "git_commits_url": "https://api.github.com/repos/web-platform-tests/wpt/git/commits{/sha}",
        "comments_url": "https://api.github.com/repos/web-platform-tests/wpt/comments{/number}",
        "issue_comment_url": "https://api.github.com/repos/web-platform-tests/wpt/issues/comments{/number}",
        "contents_url": "https://api.github.com/repos/web-platform-tests/wpt/contents/{+path}",
        "compare_url": "https://api.github.com/repos/web-platform-tests/wpt/compare/{base}...{head}",
        "merges_url": "https://api.github.com/repos/web-platform-tests/wpt/merges",
        "archive_url": "https://api.github.com/repos/web-platform-tests/wpt/{archive_format}{/ref}",
        "downloads_url": "https://api.github.com/repos/web-platform-tests/wpt/downloads",
        "issues_url": "https://api.github.com/repos/web-platform-tests/wpt/issues{/number}",
        "pulls_url": "https://api.github.com/repos/web-platform-tests/wpt/pulls{/number}",
        "milestones_url": "https://api.github.com/repos/web-platform-tests/wpt/milestones{/number}",
        "notifications_url": "https://api.github.com/repos/web-platform-tests/wpt/notifications{?since,all,participating}",
        "labels_url": "https://api.github.com/repos/web-platform-tests/wpt/labels{/name}",
        "releases_url": "https://api.github.com/repos/web-platform-tests/wpt/releases{/id}",
        "deployments_url": "https://api.github.com/repos/web-platform-tests/wpt/deployments",
        "created_at": "2012-03-04T12:58:11Z",
        "updated_at": "2019-11-08T13:49:51Z",
        "pushed_at": "2019-11-08T15:45:46Z",
        "git_url": "git://github.com/web-platform-tests/wpt.git",
        "ssh_url": "[email protected]:web-platform-tests/wpt.git",
        "clone_url": "https://github.com/web-platform-tests/wpt.git",
        "svn_url": "https://github.com/web-platform-tests/wpt",
        "homepage": "https://web-platform-tests.org/",
        "size": 328727,
        "stargazers_count": 2516,
        "watchers_count": 2516,
        "language": "HTML",
        "has_issues": true,
        "has_projects": true,
        "has_downloads": true,
        "has_wiki": true,
        "has_pages": true,
        "forks_count": 1827,
        "mirror_url": null,
        "archived": false,
        "disabled": false,
        "open_issues_count": 1582,
        "license": {
          "key": "other",
          "name": "Other",
          "spdx_id": "NOASSERTION",
          "url": null,
          "node_id": "MDc6TGljZW5zZTA="
        },
        "forks": 1827,
        "open_issues": 1582,
        "watchers": 2516,
        "default_branch": "master"
      }
    },
    "base": {
      "label": "web-platform-tests:master",
      "ref": "master",
      "sha": "2cc5a5ca83698ffd79abf7b6671aebc44c354d04",
      "user": {
        "login": "web-platform-tests",
        "id": 37226233,
        "node_id": "MDEyOk9yZ2FuaXphdGlvbjM3MjI2MjMz",
        "avatar_url": "https://avatars0.githubusercontent.com/u/37226233?v=4",
        "gravatar_id": "",
        "url": "https://api.github.com/users/web-platform-tests",
        "html_url": "https://github.com/web-platform-tests",
        "followers_url": "https://api.github.com/users/web-platform-tests/followers",
        "following_url": "https://api.github.com/users/web-platform-tests/following{/other_user}",
        "gists_url": "https://api.github.com/users/web-platform-tests/gists{/gist_id}",
        "starred_url": "https://api.github.com/users/web-platform-tests/starred{/owner}{/repo}",
        "subscriptions_url": "https://api.github.com/users/web-platform-tests/subscriptions",
        "organizations_url": "https://api.github.com/users/web-platform-tests/orgs",
        "repos_url": "https://api.github.com/users/web-platform-tests/repos",
        "events_url": "https://api.github.com/users/web-platform-tests/events{/privacy}",
        "received_events_url": "https://api.github.com/users/web-platform-tests/received_events",
        "type": "Organization",
        "site_admin": false
      },
      "repo": {
        "id": 3618133,
        "node_id": "MDEwOlJlcG9zaXRvcnkzNjE4MTMz",
        "name": "wpt",
        "full_name": "web-platform-tests/wpt",
        "private": false,
        "owner": {
          "login": "web-platform-tests",
          "id": 37226233,
          "node_id": "MDEyOk9yZ2FuaXphdGlvbjM3MjI2MjMz",
          "avatar_url": "https://avatars0.githubusercontent.com/u/37226233?v=4",
          "gravatar_id": "",
          "url": "https://api.github.com/users/web-platform-tests",
          "html_url": "https://github.com/web-platform-tests",
          "followers_url": "https://api.github.com/users/web-platform-tests/followers",
          "following_url": "https://api.github.com/users/web-platform-tests/following{/other_user}",
          "gists_url": "https://api.github.com/users/web-platform-tests/gists{/gist_id}",
          "starred_url": "https://api.github.com/users/web-platform-tests/starred{/owner}{/repo}",
          "subscriptions_url": "https://api.github.com/users/web-platform-tests/subscriptions",
          "organizations_url": "https://api.github.com/users/web-platform-tests/orgs",
          "repos_url": "https://api.github.com/users/web-platform-tests/repos",
          "events_url": "https://api.github.com/users/web-platform-tests/events{/privacy}",
          "received_events_url": "https://api.github.com/users/web-platform-tests/received_events",
          "type": "Organization",
          "site_admin": false
        },
        "html_url": "https://github.com/web-platform-tests/wpt",
        "description": "Test suites for Web platform specs — including WHATWG, W3C, and others",
        "fork": false,
        "url": "https://api.github.com/repos/web-platform-tests/wpt",
        "forks_url": "https://api.github.com/repos/web-platform-tests/wpt/forks",
        "keys_url": "https://api.github.com/repos/web-platform-tests/wpt/keys{/key_id}",
        "collaborators_url": "https://api.github.com/repos/web-platform-tests/wpt/collaborators{/collaborator}",
        "teams_url": "https://api.github.com/repos/web-platform-tests/wpt/teams",
        "hooks_url": "https://api.github.com/repos/web-platform-tests/wpt/hooks",
        "issue_events_url": "https://api.github.com/repos/web-platform-tests/wpt/issues/events{/number}",
        "events_url": "https://api.github.com/repos/web-platform-tests/wpt/events",
        "assignees_url": "https://api.github.com/repos/web-platform-tests/wpt/assignees{/user}",
        "branches_url": "https://api.github.com/repos/web-platform-tests/wpt/branches{/branch}",
        "tags_url": "https://api.github.com/repos/web-platform-tests/wpt/tags",
        "blobs_url": "https://api.github.com/repos/web-platform-tests/wpt/git/blobs{/sha}",
        "git_tags_url": "https://api.github.com/repos/web-platform-tests/wpt/git/tags{/sha}",
        "git_refs_url": "https://api.github.com/repos/web-platform-tests/wpt/git/refs{/sha}",
        "trees_url": "https://api.github.com/repos/web-platform-tests/wpt/git/trees{/sha}",
        "statuses_url": "https://api.github.com/repos/web-platform-tests/wpt/statuses/{sha}",
        "languages_url": "https://api.github.com/repos/web-platform-tests/wpt/languages",
        "stargazers_url": "https://api.github.com/repos/web-platform-tests/wpt/stargazers",
        "contributors_url": "https://api.github.com/repos/web-platform-tests/wpt/contributors",
        "subscribers_url": "https://api.github.com/repos/web-platform-tests/wpt/subscribers",
        "subscription_url": "https://api.github.com/repos/web-platform-tests/wpt/subscription",
        "commits_url": "https://api.github.com/repos/web-platform-tests/wpt/commits{/sha}",
        "git_commits_url": "https://api.github.com/repos/web-platform-tests/wpt/git/commits{/sha}",
        "comments_url": "https://api.github.com/repos/web-platform-tests/wpt/comments{/number}",
        "issue_comment_url": "https://api.github.com/repos/web-platform-tests/wpt/issues/comments{/number}",
        "contents_url": "https://api.github.com/repos/web-platform-tests/wpt/contents/{+path}",
        "compare_url": "https://api.github.com/repos/web-platform-tests/wpt/compare/{base}...{head}",
        "merges_url": "https://api.github.com/repos/web-platform-tests/wpt/merges",
        "archive_url": "https://api.github.com/repos/web-platform-tests/wpt/{archive_format}{/ref}",
        "downloads_url": "https://api.github.com/repos/web-platform-tests/wpt/downloads",
        "issues_url": "https://api.github.com/repos/web-platform-tests/wpt/issues{/number}",
        "pulls_url": "https://api.github.com/repos/web-platform-tests/wpt/pulls{/number}",
        "milestones_url": "https://api.github.com/repos/web-platform-tests/wpt/milestones{/number}",
        "notifications_url": "https://api.github.com/repos/web-platform-tests/wpt/notifications{?since,all,participating}",
        "labels_url": "https://api.github.com/repos/web-platform-tests/wpt/labels{/name}",
        "releases_url": "https://api.github.com/repos/web-platform-tests/wpt/releases{/id}",
        "deployments_url": "https://api.github.com/repos/web-platform-tests/wpt/deployments",
        "created_at": "2012-03-04T12:58:11Z",
        "updated_at": "2019-11-08T13:49:51Z",
        "pushed_at": "2019-11-08T15:45:46Z",
        "git_url": "git://github.com/web-platform-tests/wpt.git",
        "ssh_url": "[email protected]:web-platform-tests/wpt.git",
        "clone_url": "https://github.com/web-platform-tests/wpt.git",
        "svn_url": "https://github.com/web-platform-tests/wpt",
        "homepage": "https://web-platform-tests.org/",
        "size": 328727,
        "stargazers_count": 2516,
        "watchers_count": 2516,
        "language": "HTML",
        "has_issues": true,
        "has_projects": true,
        "has_downloads": true,
        "has_wiki": true,
        "has_pages": true,
        "forks_count": 1827,
        "mirror_url": null,
        "archived": false,
        "disabled": false,
        "open_issues_count": 1582,
        "license": {
          "key": "other",
          "name": "Other",
          "spdx_id": "NOASSERTION",
          "url": null,
          "node_id": "MDc6TGljZW5zZTA="
        },
        "forks": 1827,
        "open_issues": 1582,
        "watchers": 2516,
        "default_branch": "master"
      }
    },
    "_links": {
      "self": {
        "href": "https://api.github.com/repos/web-platform-tests/wpt/pulls/20176"
      },
      "html": {
        "href": "https://github.com/web-platform-tests/wpt/pull/20176"
      },
      "issue": {
        "href": "https://api.github.com/repos/web-platform-tests/wpt/issues/20176"
      },
      "comments": {
        "href": "https://api.github.com/repos/web-platform-tests/wpt/issues/20176/comments"
      },
      "review_comments": {
        "href": "https://api.github.com/repos/web-platform-tests/wpt/pulls/20176/comments"
      },
      "review_comment": {
        "href": "https://api.github.com/repos/web-platform-tests/wpt/pulls/comments{/number}"
      },
      "commits": {
        "href": "https://api.github.com/repos/web-platform-tests/wpt/pulls/20176/commits"
      },
      "statuses": {
        "href": "https://api.github.com/repos/web-platform-tests/wpt/statuses/911c33927a1c01ee0ecf50efd60e0e238e6e2f95"
      }
    },
    "author_association": "CONTRIBUTOR"
  },
  "repository": {
    "id": 3618133,
    "node_id": "MDEwOlJlcG9zaXRvcnkzNjE4MTMz",
    "name": "wpt",
    "full_name": "web-platform-tests/wpt",
    "private": false,
    "owner": {
      "login": "web-platform-tests",
      "id": 37226233,
      "node_id": "MDEyOk9yZ2FuaXphdGlvbjM3MjI2MjMz",
      "avatar_url": "https://avatars0.githubusercontent.com/u/37226233?v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/web-platform-tests",
      "html_url": "https://github.com/web-platform-tests",
      "followers_url": "https://api.github.com/users/web-platform-tests/followers",
      "following_url": "https://api.github.com/users/web-platform-tests/following{/other_user}",
      "gists_url": "https://api.github.com/users/web-platform-tests/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/web-platform-tests/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/web-platform-tests/subscriptions",
      "organizations_url": "https://api.github.com/users/web-platform-tests/orgs",
      "repos_url": "https://api.github.com/users/web-platform-tests/repos",
      "events_url": "https://api.github.com/users/web-platform-tests/events{/privacy}",
      "received_events_url": "https://api.github.com/users/web-platform-tests/received_events",
      "type": "Organization",
      "site_admin": false
    },
    "html_url": "https://github.com/web-platform-tests/wpt",
    "description": "Test suites for Web platform specs — including WHATWG, W3C, and others",
    "fork": false,
    "url": "https://api.github.com/repos/web-platform-tests/wpt",
    "forks_url": "https://api.github.com/repos/web-platform-tests/wpt/forks",
    "keys_url": "https://api.github.com/repos/web-platform-tests/wpt/keys{/key_id}",
    "collaborators_url": "https://api.github.com/repos/web-platform-tests/wpt/collaborators{/collaborator}",
    "teams_url": "https://api.github.com/repos/web-platform-tests/wpt/teams",
    "hooks_url": "https://api.github.com/repos/web-platform-tests/wpt/hooks",
    "issue_events_url": "https://api.github.com/repos/web-platform-tests/wpt/issues/events{/number}",
    "events_url": "https://api.github.com/repos/web-platform-tests/wpt/events",
    "assignees_url": "https://api.github.com/repos/web-platform-tests/wpt/assignees{/user}",
    "branches_url": "https://api.github.com/repos/web-platform-tests/wpt/branches{/branch}",
    "tags_url": "https://api.github.com/repos/web-platform-tests/wpt/tags",
    "blobs_url": "https://api.github.com/repos/web-platform-tests/wpt/git/blobs{/sha}",
    "git_tags_url": "https://api.github.com/repos/web-platform-tests/wpt/git/tags{/sha}",
    "git_refs_url": "https://api.github.com/repos/web-platform-tests/wpt/git/refs{/sha}",
    "trees_url": "https://api.github.com/repos/web-platform-tests/wpt/git/trees{/sha}",
    "statuses_url": "https://api.github.com/repos/web-platform-tests/wpt/statuses/{sha}",
    "languages_url": "https://api.github.com/repos/web-platform-tests/wpt/languages",
    "stargazers_url": "https://api.github.com/repos/web-platform-tests/wpt/stargazers",
    "contributors_url": "https://api.github.com/repos/web-platform-tests/wpt/contributors",
    "subscribers_url": "https://api.github.com/repos/web-platform-tests/wpt/subscribers",
    "subscription_url": "https://api.github.com/repos/web-platform-tests/wpt/subscription",
    "commits_url": "https://api.github.com/repos/web-platform-tests/wpt/commits{/sha}",
    "git_commits_url": "https://api.github.com/repos/web-platform-tests/wpt/git/commits{/sha}",
    "comments_url": "https://api.github.com/repos/web-platform-tests/wpt/comments{/number}",
    "issue_comment_url": "https://api.github.com/repos/web-platform-tests/wpt/issues/comments{/number}",
    "contents_url": "https://api.github.com/repos/web-platform-tests/wpt/contents/{+path}",
    "compare_url": "https://api.github.com/repos/web-platform-tests/wpt/compare/{base}...{head}",
    "merges_url": "https://api.github.com/repos/web-platform-tests/wpt/merges",
    "archive_url": "https://api.github.com/repos/web-platform-tests/wpt/{archive_format}{/ref}",
    "downloads_url": "https://api.github.com/repos/web-platform-tests/wpt/downloads",
    "issues_url": "https://api.github.com/repos/web-platform-tests/wpt/issues{/number}",
    "pulls_url": "https://api.github.com/repos/web-platform-tests/wpt/pulls{/number}",
    "milestones_url": "https://api.github.com/repos/web-platform-tests/wpt/milestones{/number}",
    "notifications_url": "https://api.github.com/repos/web-platform-tests/wpt/notifications{?since,all,participating}",
    "labels_url": "https://api.github.com/repos/web-platform-tests/wpt/labels{/name}",
    "releases_url": "https://api.github.com/repos/web-platform-tests/wpt/releases{/id}",
    "deployments_url": "https://api.github.com/repos/web-platform-tests/wpt/deployments",
    "created_at": "2012-03-04T12:58:11Z",
    "updated_at": "2019-11-08T13:49:51Z",
    "pushed_at": "2019-11-08T15:45:46Z",
    "git_url": "git://github.com/web-platform-tests/wpt.git",
    "ssh_url": "[email protected]:web-platform-tests/wpt.git",
    "clone_url": "https://github.com/web-platform-tests/wpt.git",
    "svn_url": "https://github.com/web-platform-tests/wpt",
    "homepage": "https://web-platform-tests.org/",
    "size": 328727,
    "stargazers_count": 2516,
    "watchers_count": 2516,
    "language": "HTML",
    "has_issues": true,
    "has_projects": true,
    "has_downloads": true,
    "has_wiki": true,
    "has_pages": true,
    "forks_count": 1827,
    "mirror_url": null,
    "archived": false,
    "disabled": false,
    "open_issues_count": 1582,
    "license": {
      "key": "other",
      "name": "Other",
      "spdx_id": "NOASSERTION",
      "url": null,
      "node_id": "MDc6TGljZW5zZTA="
    },
    "forks": 1827,
    "open_issues": 1582,
    "watchers": 2516,
    "default_branch": "master"
  },
  "organization": {
    "login": "web-platform-tests",
    "id": 37226233,
    "node_id": "MDEyOk9yZ2FuaXphdGlvbjM3MjI2MjMz",
    "url": "https://api.github.com/orgs/web-platform-tests",
    "repos_url": "https://api.github.com/orgs/web-platform-tests/repos",
    "events_url": "https://api.github.com/orgs/web-platform-tests/events",
    "hooks_url": "https://api.github.com/orgs/web-platform-tests/hooks",
    "issues_url": "https://api.github.com/orgs/web-platform-tests/issues",
    "members_url": "https://api.github.com/orgs/web-platform-tests/members{/member}",
    "public_members_url": "https://api.github.com/orgs/web-platform-tests/public_members{/member}",
    "avatar_url": "https://avatars0.githubusercontent.com/u/37226233?v=4",
    "description": ""
  },
  "sender": {
    "login": "foolip",
    "id": 498917,
    "node_id": "MDQ6VXNlcjQ5ODkxNw==",
    "avatar_url": "https://avatars1.githubusercontent.com/u/498917?v=4",
    "gravatar_id": "",
    "url": "https://api.github.com/users/foolip",
    "html_url": "https://github.com/foolip",
    "followers_url": "https://api.github.com/users/foolip/followers",
    "following_url": "https://api.github.com/users/foolip/following{/other_user}",
    "gists_url": "https://api.github.com/users/foolip/gists{/gist_id}",
    "starred_url": "https://api.github.com/users/foolip/starred{/owner}{/repo}",
    "subscriptions_url": "https://api.github.com/users/foolip/subscriptions",
    "organizations_url": "https://api.github.com/users/foolip/orgs",
    "repos_url": "https://api.github.com/users/foolip/repos",
    "events_url": "https://api.github.com/users/foolip/events{/privacy}",
    "received_events_url": "https://api.github.com/users/foolip/received_events",
    "type": "User",
    "site_admin": false
  }
}

@foolip
Copy link
Member Author

foolip commented Nov 8, 2019

I suspect #110 could plug this last hole, but I'm not too sure.

@foolip
Copy link
Member Author

foolip commented Nov 12, 2019

Going through the steps given the payload in #69 (comment) I think I see the problem:

So #110 would fix this.

@foolip foolip mentioned this issue Nov 12, 2019
Merged
@stephenmcgruer
Copy link
Contributor

#110 has landed; I take it this is fixed then @foolip ?

@foolip
Copy link
Member Author

foolip commented Jan 8, 2020

Yes, this is fixed as far as I can tell. web-platform-tests/wpt#20724 is an example of the bot staying away as it should.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@stephenmcgruer @zcorpan @foolip @jugglinmike and others