fix: sdk types #1058
Open
fix: sdk types #1058
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the SDK types used in the tests to align with recent changes in the SDK implementation. The key changes include:
- Changing the import of the Node.js "path" module from a default import to a namespace import.
- Updating the type for the "sdk" property in the MockSDKResponse interface from RsdoctorSDK to SDK.RsdoctorSDKInstance.
Comments suppressed due to low confidence (1)
packages/sdk/tests/utils.ts:10
- The change in the SDK type in the MockSDKResponse interface is clear; please ensure that related tests and client code expecting RsdoctorSDK are updated accordingly to prevent type mismatches.
sdk: SDK.RsdoctorSDKInstance;
✅ Deploy Preview for rsdoctor ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix: sdk types
Related Links