fix(sdk): saveManifest need await when brief mode (#498)

web-infra-dev · Sep 3, 2024 · bf543ec · bf543ec
1 parent 5b5a67c
commit bf543ec
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 3 deletions.
diff --git a/.changeset/stupid-comics-mate.md b/.changeset/stupid-comics-mate.md
@@ -0,0 +1,6 @@
+---
+'@rsdoctor/webpack-plugin': patch
+'@rsdoctor/sdk': patch
+---
+
+fix(sdk): saveManifest need await when brief mode
diff --git a/packages/sdk/src/sdk/sdk/webpack.ts b/packages/sdk/src/sdk/sdk/webpack.ts
@@ -373,15 +373,15 @@ export class RsdoctorWebpackSDK<
     }
   }
 
-  public writeStore(options?: SDK.WriteStoreOptionsType) {
+  public async writeStore(options?: SDK.WriteStoreOptionsType) {
     debug(() => `sdk.writeStore has run.`, '[SDK.writeStore][end]');
     if (this.extraConfig?.mode === SDK.IMode[SDK.IMode.brief]) {
       const clientHtmlPath = this.extraConfig.innerClientPath
         ? this.extraConfig.innerClientPath
         : require.resolve('@rsdoctor/client');
 
       if (this.extraConfig.brief?.writeDataJson) {
-        this.saveManifest(this.getStoreData(), options || {});
+        await this.saveManifest(this.getStoreData(), options || {});
       }
       return this.inlineScriptsAndStyles(clientHtmlPath);
     }

diff --git a/packages/webpack-plugin/src/plugin.ts b/packages/webpack-plugin/src/plugin.ts
@@ -214,6 +214,8 @@ export class RsdoctorWebpackPlugin<Rules extends Linter.ExtendRuleData[]>
         );
         openBrowser(`file:///${outputFilePath}`);
       }
-    } catch (e) {}
+    } catch (e) {
+      console.error(`[Rsdoctor] Webpack plugin this.done error`, e);
+    }
   };
 }