perf: bundle rslog dependency to main chunk #6746
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
chenjiahan
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes the bundling strategy for the rslog dependency by bundling it directly into the main chunk instead of loading it via require() calls at runtime, reducing the number of dynamic module loads and improving performance.
Key Changes:
- Converted rslog from a pre-bundled compiled dependency to a directly bundled dependency
- Updated import statements to use static ES imports instead of dynamic require
- Modified prebundle configuration to only process types for rslog
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/core/src/logger.ts | Changed from dynamic require to static import of rslog logger and type |
| packages/core/src/helpers/vendors.ts | Removed rslog from CompiledPackages type as it's no longer a compiled dependency |
| packages/core/rslib.config.ts | Added type alias for rslog to point to compiled types and improved comment grammar |
| packages/core/prebundle.config.ts | Configured rslog as dtsOnly to bundle types without runtime code prebundling |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bundle the rslog dependency to main chunk to reduce
require()calls.Checklist