Skip to content

fix: retain currentScript reference when processing async/defer script #718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hemisu
Copy link

@hemisu hemisu commented Apr 23, 2025

Description

retain currentScript reference when processing async/defer scripts to prevent data-* attribute read failures

dev/app-react-18/public/index.html

<script
      src="./scripts/readCurrentScript.js"
      data-appkey="supply"
      async="true"
    ></script>

the currentScript property will not be read

Related Issue

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation.

…ts to prevent data-* attribute read failures
Copy link

vercel bot commented Apr 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
garfish ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2025 7:38am

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants