Allow id-card authentication when Extended Key Usage is not present in certificate #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n certificate WE2-1028 Signed-off-by: Sven Mitt <[email protected]>
WE2-1028 Signed-off-by: Sven Mitt <[email protected]>
WE2-1028 Signed-off-by: Sven Mitt <[email protected]>
WE2-1028 Signed-off-by: Sven Mitt <[email protected]>
WE2-1028 Signed-off-by: Sven Mitt <[email protected]>
mrts
requested changes
May 13, 2025
| if (in_array($algorithm, self::RSASSA_PSS_ALGORITHMS)) { | ||
| $publicKey = openssl_get_publickey($publicKey->withPadding(RSA::SIGNATURE_PSS)->toString('PSS')); | ||
| if (!$publicKey) { | ||
| throw new AuthTokenParseException(); |
There was a problem hiding this comment.
I think exception message is needed here as the context is different than elsewhere.
| if (!$usages || empty($usages)) { | ||
| // Digital Signature extension present, but Extended Key Usage extension not present, | ||
| // assume it is an authentication certificate (e.g. Luxembourg eID). | ||
| return; |
There was a problem hiding this comment.
Line 76 has a debug log message, it is needed here as well before return for consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sven Mitt [email protected]