Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DR-144 clarify embedded close #1693

Merged
merged 7 commits into from
Feb 23, 2024
Merged

Conversation

daveatweaviate
Copy link
Contributor

@daveatweaviate daveatweaviate changed the title Dr 144 clarify embedded close DR-144 clarify embedded close Feb 15, 2024
Copy link
Contributor Author

@daveatweaviate daveatweaviate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notes for reviewers.

@@ -49,6 +49,7 @@
"semitechnologies",
"sharded",
"shukri",
"Snowpark",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore - VSCode dictionary word

<FilteredTextBlock
text={PyCode}
startMarker="# START SimpleInstantiationEmbedded"
endMarker="# END SimpleInstantiationEmbedded"
startMarker="# START FullInstantiationEmbedded"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kept both versions for now in case we want to revert.

@@ -77,6 +77,7 @@ If you try out new features, please provide [feedback](https://github.com/weavia


## Related pages
- [Connect to Weaviate](../tutorials/connect.mdx)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From here down, the only change is a link to the connection tutorial

@daveatweaviate daveatweaviate merged commit 2eb3cb6 into main Feb 23, 2024
2 checks passed
@daveatweaviate daveatweaviate deleted the DR-144-clarify-embedded-close branch March 1, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant